Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 2315453002: [arm] Improve generation of flag setting instructions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/unittests/compiler/arm/instruction-selector-arm-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/base/bits.h" 6 #include "src/base/bits.h"
7 #include "src/compiler/instruction-selector-impl.h" 7 #include "src/compiler/instruction-selector-impl.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 10
(...skipping 1940 matching lines...) Expand 10 before | Expand all | Expand 10 after
1951 case IrOpcode::kWord32Shr: 1951 case IrOpcode::kWord32Shr:
1952 return VisitShift(selector, value, TryMatchLSR, cont); 1952 return VisitShift(selector, value, TryMatchLSR, cont);
1953 case IrOpcode::kWord32Ror: 1953 case IrOpcode::kWord32Ror:
1954 return VisitShift(selector, value, TryMatchROR, cont); 1954 return VisitShift(selector, value, TryMatchROR, cont);
1955 default: 1955 default:
1956 break; 1956 break;
1957 } 1957 }
1958 break; 1958 break;
1959 } 1959 }
1960 1960
1961 if (user->opcode() == IrOpcode::kWord32Equal) {
1962 return VisitWordCompare(selector, user, cont);
1963 }
1964
1961 // Continuation could not be combined with a compare, emit compare against 0. 1965 // Continuation could not be combined with a compare, emit compare against 0.
1962 ArmOperandGenerator g(selector); 1966 ArmOperandGenerator g(selector);
1963 InstructionCode const opcode = 1967 InstructionCode const opcode =
1964 cont->Encode(kArmTst) | AddressingModeField::encode(kMode_Operand2_R); 1968 cont->Encode(kArmTst) | AddressingModeField::encode(kMode_Operand2_R);
1965 InstructionOperand const value_operand = g.UseRegister(value); 1969 InstructionOperand const value_operand = g.UseRegister(value);
1966 if (cont->IsBranch()) { 1970 if (cont->IsBranch()) {
1967 selector->Emit(opcode, g.NoOutput(), value_operand, value_operand, 1971 selector->Emit(opcode, g.NoOutput(), value_operand, value_operand,
1968 g.Label(cont->true_block()), g.Label(cont->false_block())); 1972 g.Label(cont->true_block()), g.Label(cont->false_block()));
1969 } else if (cont->IsDeoptimize()) { 1973 } else if (cont->IsDeoptimize()) {
1970 selector->EmitDeoptimize(opcode, g.NoOutput(), value_operand, value_operand, 1974 selector->EmitDeoptimize(opcode, g.NoOutput(), value_operand, value_operand,
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
2259 Vector<MachineType> req_aligned = Vector<MachineType>::New(2); 2263 Vector<MachineType> req_aligned = Vector<MachineType>::New(2);
2260 req_aligned[0] = MachineType::Float32(); 2264 req_aligned[0] = MachineType::Float32();
2261 req_aligned[1] = MachineType::Float64(); 2265 req_aligned[1] = MachineType::Float64();
2262 return MachineOperatorBuilder::AlignmentRequirements:: 2266 return MachineOperatorBuilder::AlignmentRequirements::
2263 SomeUnalignedAccessUnsupported(req_aligned, req_aligned); 2267 SomeUnalignedAccessUnsupported(req_aligned, req_aligned);
2264 } 2268 }
2265 2269
2266 } // namespace compiler 2270 } // namespace compiler
2267 } // namespace internal 2271 } // namespace internal
2268 } // namespace v8 2272 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/unittests/compiler/arm/instruction-selector-arm-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698