Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2315443003: Stop sending serialized SSLStatus to the renderer. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, apavlov+blink_chromium.org, kinuko+watch, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, pfeldman+blink_chromium.org, jam, abarth-chromium, dglazkov+blink, caseq+blink_chromium.org, darin-cc_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Randy Smith (Not in Mondays), lushnikov+blink_chromium.org, loading-reviews_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, Yoav Weiss, Aaron Boodman, pfeldman, darin (slow to review), mmenke, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop sending serialized SSLStatus to the renderer. It's not used anymore after previous changes referenced in these bugs. This is working towards removing CertStore. BUG=598073, 504347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/c94a753f93a6b1e7e950d6eaa8814cba7d3aeb54 Cr-Commit-Position: refs/heads/master@{#417032}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : merge #

Total comments: 2

Patch Set 4 : self review fix and merge fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -763 lines) Patch
M chrome/renderer/extensions/extension_localization_peer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 7 chunks +28 lines, -29 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M content/browser/download/download_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_file_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/detachable_resource_handler.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/layered_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/layered_resource_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 12 chunks +10 lines, -14 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/navigation_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 5 chunks +24 lines, -31 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 2 2 chunks +0 lines, -95 lines 0 comments Download
M content/browser/loader/resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 3 chunks +0 lines, -80 lines 0 comments Download
M content/browser/loader/stream_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/stream_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/sync_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 7 chunks +3 lines, -10 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M content/common/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/resource_messages.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/resource_request_completion_status.h View 1 chunk +0 lines, -3 lines 0 comments Download
D content/common/ssl_status_serialization.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/common/ssl_status_serialization.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D content/common/ssl_status_serialization_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/child/request_peer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/resource_response.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/resource_response_info.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 1 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
jam
Tom: content/common/resource_messages.h Pavel: the rest (pretty mechanical after the last cl) https://codereview.chromium.org/2315443003/diff/60001/content/browser/loader/resource_dispatcher_host_unittest.cc File content/browser/loader/resource_dispatcher_host_unittest.cc (left): ...
4 years, 3 months ago (2016-09-06 21:08:24 UTC) #16
Tom Sepez
messages LGTM.
4 years, 3 months ago (2016-09-06 21:13:56 UTC) #17
pfeldman
lgtm
4 years, 3 months ago (2016-09-07 18:21:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315443003/100001
4 years, 3 months ago (2016-09-07 19:34:10 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 3 months ago (2016-09-07 19:40:52 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:43:04 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c94a753f93a6b1e7e950d6eaa8814cba7d3aeb54
Cr-Commit-Position: refs/heads/master@{#417032}

Powered by Google App Engine
This is Rietveld 408576698