Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2315443003: Stop sending serialized SSLStatus to the renderer. (Closed)
Patch Set: self review fix and merge fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index 3903e28aa3d7e0dc25e3145f660a2288dfc68287..55276552e0a0e7bb80a5d77f98024a801b4521de 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -339,7 +339,7 @@ class WebURLLoaderImplTest : public testing::Test {
void DoCompleteRequest() {
EXPECT_FALSE(client()->did_finish());
- peer()->OnCompletedRequest(net::OK, false, false, "", base::TimeTicks(),
+ peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(),
strlen(kTestData));
EXPECT_TRUE(client()->did_finish());
// There should be no error.
@@ -349,7 +349,7 @@ class WebURLLoaderImplTest : public testing::Test {
void DoFailRequest() {
EXPECT_FALSE(client()->did_finish());
- peer()->OnCompletedRequest(net::ERR_FAILED, false, false, "",
+ peer()->OnCompletedRequest(net::ERR_FAILED, false, false,
base::TimeTicks(), strlen(kTestData));
EXPECT_FALSE(client()->did_finish());
EXPECT_EQ(net::ERR_FAILED, client()->error().reason);
@@ -402,18 +402,6 @@ TEST_F(WebURLLoaderImplTest, Redirect) {
EXPECT_EQ(kTestData, client()->received_data());
}
-// Tests that a redirect to an HTTPS URL with no security info does not
-// crash. Regression test for https://crbug.com/519120
-TEST_F(WebURLLoaderImplTest, RedirectToHTTPSWithEmptySecurityInfo) {
- DoStartAsyncRequest();
- DoReceiveHTTPSRedirect();
- DoReceiveResponse();
- DoReceiveData();
- DoCompleteRequest();
- EXPECT_FALSE(dispatcher()->canceled());
- EXPECT_EQ(kTestData, client()->received_data());
-}
-
TEST_F(WebURLLoaderImplTest, RedirectCorrectPriority) {
DoStartAsyncRequestWithPriority(
blink::WebURLRequest::Priority::PriorityVeryHigh);
@@ -607,7 +595,7 @@ TEST_F(WebURLLoaderImplTest, FtpDeleteOnReceiveMoreData) {
// Directory listings are only parsed once the request completes, so this will
// cancel in DoReceiveDataFtp, before the request finishes.
client()->set_delete_on_receive_data();
- peer()->OnCompletedRequest(net::OK, false, false, "", base::TimeTicks(),
+ peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(),
strlen(kTestData));
EXPECT_FALSE(client()->did_finish());
}
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698