Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2315283002:
SkLiteDL: drawAsLayer() (Closed)
DescriptionSkLiteDL: drawAsLayer()
This more or less the API you were thinking?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002
Committed: https://skia.googlesource.com/skia/+/f53fcc8ccaaa5e3cd24846d9e3ac38ad311f3711
Patch Set 1 #
Total comments: 4
Patch Set 2 : reed #Patch Set 3 : tweaks #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== SkLiteDL: drawAsLayer() This more or less what you were thinking? BUG=skia: ========== to ========== SkLiteDL: drawAsLayer() This more or less what you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 ==========
Description was changed from ========== SkLiteDL: drawAsLayer() This more or less what you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 ========== to ========== SkLiteDL: drawAsLayer() This more or less the API you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 ==========
mtklein@chromium.org changed reviewers: + djsollen@google.com, reed@google.com
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h File src/core/SkLiteDL.h (right): https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h#newcode39 src/core/SkLiteDL.h:39: void drawAsLayer(SkCanvas* c, const SkMatrix* matrix yep, though in my current case matrix will always be a nullptr.
https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.cpp File src/core/SkLiteDL.cpp (right): https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.cpp#newco... src/core/SkLiteDL.cpp:826: auto fallback_plan = [&] { cool way to construct this. https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h File src/core/SkLiteDL.h (right): https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h#newcode39 src/core/SkLiteDL.h:39: void drawAsLayer(SkCanvas* c, const SkMatrix* matrix On 2016/09/07 14:31:36, djsollen wrote: > yep, though in my current case matrix will always be a nullptr. drawPicture has nearly this signature already: canvas->drawPicture(picture, matrix, layerPaint) I think this guy should take a paint* instead of separate params: - matches drawPicture (and saveLayer for that matter) - can be well defined (given the other layer-paint uses as to which fields are respected) - automatically gets other fields (not yet respected by android.. yet) like imagefilter
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h File src/core/SkLiteDL.h (right): https://codereview.chromium.org/2315283002/diff/1/src/core/SkLiteDL.h#newcode39 src/core/SkLiteDL.h:39: void drawAsLayer(SkCanvas* c, const SkMatrix* matrix On 2016/09/07 15:29:55, reed1 wrote: > On 2016/09/07 14:31:36, djsollen wrote: > > yep, though in my current case matrix will always be a nullptr. > > drawPicture has nearly this signature already: > > canvas->drawPicture(picture, matrix, layerPaint) > > I think this guy should take a paint* instead of separate params: > - matches drawPicture (and saveLayer for that matter) > - can be well defined (given the other layer-paint uses as to which fields are > respected) > - automatically gets other fields (not yet respected by android.. yet) like > imagefilter sgtm, ptal
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== SkLiteDL: drawAsLayer() This more or less the API you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 ========== to ========== SkLiteDL: drawAsLayer() This more or less the API you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 Committed: https://skia.googlesource.com/skia/+/f53fcc8ccaaa5e3cd24846d9e3ac38ad311f3711 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/f53fcc8ccaaa5e3cd24846d9e3ac38ad311f3711 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
