[CacheStorage] Sort QueryCache results by time entered into cache

[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response,
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821
Committed: https://crrev.com/92afbef3c43ccd4e0817d03a2166a98342a88d84
Cr-Commit-Position: refs/heads/master@{#417279}

[jkarlin, 2016-09-07 18:01:59]

Description was changed from

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

BUG=627821
==========

to

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response, 
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821
==========

[jkarlin, 2016-09-07 18:32:57]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-09-07 18:34:12]

jkarlin@chromium.org changed reviewers:
+ nhiroki@chromium.org

[jkarlin, 2016-09-07 18:34:13]

nhiroki@ PTAL, thanks!

[commit-bot: I haz the power, 2016-09-07 18:36:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 18:36:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jkarlin, 2016-09-07 19:06:23]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:06:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 20:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:40:17]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-09-08 03:54:56]

LGTM with minor comments.

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js
(right):

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:151:
var p = Promise.resolve();
Is this used?

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:162:
return test_function(cache, hash);
You could combine this '.then' with the previous '.then'.

.then(function() {
    assert_equals(Object.keys(hash).length, entries.length);
    return test_function(cache, hash);
  })

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:182:
'Test setup failed for entry ' + entry.name + ': ' + e);
+2-spaces indent for an argument?

[jkarlin, 2016-09-08 12:03:06]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-09-08 12:03:06]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2315253002/#ps100001
(title: "Address comments from PS5")

[jkarlin, 2016-09-08 12:03:13]

Thanks!

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js
(right):

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:151:
var p = Promise.resolve();
On 2016/09/08 03:54:56, nhiroki wrote:
> Is this used?

Nope, thanks!

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:162:
return test_function(cache, hash);
On 2016/09/08 03:54:56, nhiroki wrote:
> You could combine this '.then' with the previous '.then'.
> 
> .then(function() {
>     assert_equals(Object.keys(hash).length, entries.length);
>     return test_function(cache, hash);
>   })

Done.

https://codereview.chromium.org/2315253002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/test-helpers.js:182:
'Test setup failed for entry ' + entry.name + ': ' + e);
On 2016/09/08 03:54:56, nhiroki wrote:
> +2-spaces indent for an argument?

Done.

[commit-bot: I haz the power, 2016-09-08 12:03:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 14:05:53]

Description was changed from

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response, 
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821
==========

to

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response, 
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821
==========

[commit-bot: I haz the power, 2016-09-08 14:05:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-08 14:07:15]

Description was changed from

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response, 
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821
==========

to

==========
[CacheStorage] Sort QueryCache results by time entered into cache

The spec says that QueryCache should iterate the request/response pairs in
insertion order. The implementation backend (SimpleCache) has an unordered
iterator. This CL adds an insertion time to each entry (defaulting to response
time for pre-existing entries) and sorts QueryCache results before returning.

In order to sort the QueryCache results, I had to clean up "QueryCacheResults":
1) Rename QueryCacheResults -> QueryCacheContext
2) Create a QueryCacheResult which contains a matching request, response,
   data handle, and entry time
3) QueryCache now returns a sorted std::vector<QueryCacheResult>

BUG=627821

Committed: https://crrev.com/92afbef3c43ccd4e0817d03a2166a98342a88d84
Cr-Commit-Position: refs/heads/master@{#417279}
==========

[commit-bot: I haz the power, 2016-09-08 14:07:16]

Patchset 6 (id:??) landed as
https://crrev.com/92afbef3c43ccd4e0817d03a2166a98342a88d84
Cr-Commit-Position: refs/heads/master@{#417279}