Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js

Issue 2315253002: [CacheStorage] Sort QueryCache results by time entered into cache (Closed)
Patch Set: Address comments from PS5 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js b/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
index 9131da6e11e211f4ead96505b319e597e86ed9d8..96bd43b673a4f78af47aca307da3ced8373d6168 100644
--- a/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
+++ b/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-keys.js
@@ -50,10 +50,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.keys(entries.a.request, {ignoreSearch: true})
.then(function(result) {
- // TODO(zino): Should use assert_request_array_equals() instead of
- // assert_request_array_equivalent() once keys() returns request
- // keys in key insertion order. Please see http://crbug.com/627821.
- assert_request_array_equivalent(
+ assert_request_array_equals(
result,
[
entries.a.request,
@@ -69,10 +66,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.keys(entries.a_with_query.request, {ignoreSearch: true})
.then(function(result) {
- // TODO(zino): Should use assert_request_array_equals() instead of
- // assert_request_array_equivalent() if once keys() returns request
- // keys in key insertion order. Please see http://crbug.com/627821.
- assert_request_array_equivalent(
+ assert_request_array_equals(
result,
[
entries.a.request,
@@ -101,7 +95,7 @@ cache_test(function(cache) {
{ignoreMethod: true});
})
.then(function(result) {
- assert_request_array_equivalent(
+ assert_request_array_equals(
result,
[
request,
@@ -130,7 +124,7 @@ cache_test(function(cache) {
{ignoreVary: true});
})
.then(function(result) {
- assert_request_array_equivalent(
+ assert_request_array_equals(
result,
[
vary_request,
@@ -165,10 +159,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.keys()
.then(function(result) {
- // TODO(zino): Should use assert_request_array_equals() instead of
- // assert_request_array_equivalent() once keys() returns request
- // keys in key insertion order. Please see http://crbug.com/627821.
- assert_request_array_equivalent(
+ assert_request_array_equals(
result,
[
entries.a.request,

Powered by Google App Engine
This is Rietveld 408576698