Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: scripts/slave/recipes/closure_compilation.py

Issue 2315123002: Fix GYP-based closure try bots while they continue getting ported to GN (Closed)
Patch Set: whoops, and update fyi config as well Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/closure_compilation.py
diff --git a/scripts/slave/recipes/closure_compilation.py b/scripts/slave/recipes/closure_compilation.py
index c3451d0c4d6cbe7bdfb4e5b066f4752defb8dfa5..f933335d56666ff196be2ea7c7ffa166c5de60f0 100644
--- a/scripts/slave/recipes/closure_compilation.py
+++ b/scripts/slave/recipes/closure_compilation.py
@@ -40,23 +40,11 @@ def RunSteps(api):
)
api.step(
- 'generate_gyp_files',
- [api.path['checkout'].join('build', 'gyp_chromium'),
+ 'run_compiler',
api.path['checkout'].join('third_party', 'closure_compiler',
iannucci 2016/09/07 02:18:43 this needs to be a list of 1 item.
Dan Beam 2016/09/07 02:21:04 Done.
- 'compiled_resources.gyp')],
+ 'run_compiler')
)
- api.chromium.compile()
-
- api.step(
- 'generate_v2_gyp_files',
- [api.path['checkout'].join('build', 'gyp_chromium'),
- api.path['checkout'].join('third_party', 'closure_compiler',
- 'compiled_resources2.gyp')],
- )
-
- api.chromium.compile(name='compile_v2')
-
def GenTests(api):
for mastername, config in MASTERS.iteritems():
« no previous file with comments | « no previous file | scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698