Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: scripts/slave/recipes/closure_compilation.py

Issue 2315123002: Fix GYP-based closure try bots while they continue getting ported to GN (Closed)
Patch Set: whoops, and update fyi config as well Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 6
7 DEPS = [ 7 DEPS = [
8 'depot_tools/bot_update', 8 'depot_tools/bot_update',
9 'chromium', 9 'chromium',
10 'depot_tools/gclient', 10 'depot_tools/gclient',
(...skipping 22 matching lines...) Expand all
33 33
34 api.bot_update.ensure_checkout(force=True) 34 api.bot_update.ensure_checkout(force=True)
35 35
36 api.python( 36 api.python(
37 'run_tests', 37 'run_tests',
38 api.path['checkout'].join('third_party', 'closure_compiler', 38 api.path['checkout'].join('third_party', 'closure_compiler',
39 'run_tests.py') 39 'run_tests.py')
40 ) 40 )
41 41
42 api.step( 42 api.step(
43 'generate_gyp_files', 43 'run_compiler',
44 [api.path['checkout'].join('build', 'gyp_chromium'),
45 api.path['checkout'].join('third_party', 'closure_compiler', 44 api.path['checkout'].join('third_party', 'closure_compiler',
iannucci 2016/09/07 02:18:43 this needs to be a list of 1 item.
Dan Beam 2016/09/07 02:21:04 Done.
46 'compiled_resources.gyp')], 45 'run_compiler')
47 ) 46 )
48 47
49 api.chromium.compile()
50
51 api.step(
52 'generate_v2_gyp_files',
53 [api.path['checkout'].join('build', 'gyp_chromium'),
54 api.path['checkout'].join('third_party', 'closure_compiler',
55 'compiled_resources2.gyp')],
56 )
57
58 api.chromium.compile(name='compile_v2')
59
60 48
61 def GenTests(api): 49 def GenTests(api):
62 for mastername, config in MASTERS.iteritems(): 50 for mastername, config in MASTERS.iteritems():
63 yield ( 51 yield (
64 api.test(config['testname']) + 52 api.test(config['testname']) +
65 api.properties.generic( 53 api.properties.generic(
66 buildername=config['buildername'], 54 buildername=config['buildername'],
67 mastername=mastername, 55 mastername=mastername,
68 ) 56 )
69 ) 57 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698