Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2315123002: Fix GYP-based closure try bots while they continue getting ported to GN (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix GYP-based closure try bots while they continue getting ported to GN R=iannucci@chromium.org BUG=644563 Committed: https://chromium.googlesource.com/chromium/tools/build/+/191bb2bd43d119b86f82d72a34dd65c86f0caa55

Patch Set 1 #

Patch Set 2 : run_compiler instead #

Patch Set 3 : typo #

Patch Set 4 : whoops, and update fyi config as well #

Total comments: 2

Patch Set 5 : list fix #

Patch Set 6 : train with script, not with eyes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -160 lines) Patch
M scripts/slave/recipes/closure_compilation.py View 1 2 3 4 1 chunk +3 lines, -15 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json View 1 2 3 4 5 1 chunk +2 lines, -72 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json View 1 1 chunk +3 lines, -73 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
Dan Beam
4 years, 3 months ago (2016-09-07 02:05:28 UTC) #1
iannucci
lgtm
4 years, 3 months ago (2016-09-07 02:09:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315123002/60001
4 years, 3 months ago (2016-09-07 02:12:15 UTC) #13
iannucci
https://codereview.chromium.org/2315123002/diff/60001/scripts/slave/recipes/closure_compilation.py File scripts/slave/recipes/closure_compilation.py (right): https://codereview.chromium.org/2315123002/diff/60001/scripts/slave/recipes/closure_compilation.py#newcode44 scripts/slave/recipes/closure_compilation.py:44: api.path['checkout'].join('third_party', 'closure_compiler', this needs to be a list of ...
4 years, 3 months ago (2016-09-07 02:18:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311b4020a8e09210)
4 years, 3 months ago (2016-09-07 02:20:25 UTC) #16
Dan Beam
https://codereview.chromium.org/2315123002/diff/60001/scripts/slave/recipes/closure_compilation.py File scripts/slave/recipes/closure_compilation.py (right): https://codereview.chromium.org/2315123002/diff/60001/scripts/slave/recipes/closure_compilation.py#newcode44 scripts/slave/recipes/closure_compilation.py:44: api.path['checkout'].join('third_party', 'closure_compiler', On 2016/09/07 02:18:43, iannucci wrote: > this ...
4 years, 3 months ago (2016-09-07 02:21:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315123002/80001
4 years, 3 months ago (2016-09-07 02:21:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315123002/100001
4 years, 3 months ago (2016-09-07 02:23:35 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/tools/build/+/191bb2bd43d119b86f82d72a34dd65c86f0caa55
4 years, 3 months ago (2016-09-07 02:27:53 UTC) #25
Dan Beam
4 years, 3 months ago (2016-09-07 16:43:47 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2313403002/ by dbeam@chromium.org.

The reason for reverting is: Hopefully reverting this fixes Closure Compilation
Linux bots:
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux

They haven't been working since build/gyp_chromium was removed.  Let's convert
back to using that again now that build/gyp_chromium was restored temporarily..

Powered by Google App Engine
This is Rietveld 408576698