Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2315083002: Fix GraphicsLayer traversal in SimCompositor (Closed)

Created:
4 years, 3 months ago by szager1
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, Sami
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GraphicsLayer traversal in SimCompositor Match what FrameView::synchronizedPaint does, rather than only traversing the mainGraphicsLayer. BUG=490942 R=chrishtr@chromium.org,skyostil@chromium.org Committed: https://crrev.com/dd7e49692b1288ee1a3774bb84062df1525de62e Cr-Commit-Position: refs/heads/master@{#416998}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix GraphicsLayer traversal in SimCompositor. #

Patch Set 3 : Drop unneeded #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp View 1 2 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
szager1
4 years, 3 months ago (2016-09-07 00:23:41 UTC) #1
Sami
lgtm % two nits. Thanks for the fix! https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right): https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp#newcode360 third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:360: Unintended ...
4 years, 3 months ago (2016-09-07 14:48:43 UTC) #2
chrishtr
https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp File third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp (right): https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp#newcode47 third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp:47: if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { I don't think you need this ...
4 years, 3 months ago (2016-09-07 16:40:49 UTC) #3
szager1
https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right): https://codereview.chromium.org/2315083002/diff/1/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp#newcode360 third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:360: On 2016/09/07 14:48:43, Sami wrote: > Unintended whitespace? Fixed. ...
4 years, 3 months ago (2016-09-07 16:53:01 UTC) #5
chrishtr
lgtm
4 years, 3 months ago (2016-09-07 16:57:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315083002/40001
4 years, 3 months ago (2016-09-07 16:57:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 18:19:39 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:22:03 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd7e49692b1288ee1a3774bb84062df1525de62e
Cr-Commit-Position: refs/heads/master@{#416998}

Powered by Google App Engine
This is Rietveld 408576698