Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2314963002: Remove the final error being generated in a scope (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -403 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +75 lines, -50 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 10 chunks +66 lines, -178 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +79 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 9 chunks +12 lines, -153 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 3 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-06 19:51:52 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-06 20:01:24 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-06 20:10:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef42c94e2b452acea75ed3be106702573382730e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698