Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2314963002: Remove the final error being generated in a scope (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 3683b7ed2ad5b4beb36fa4117b9d9144dea31cf1..3c9c426c709f019db5c771bf8706b6c499c56425 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -1596,10 +1596,12 @@ class BuildLibraryElementTask extends SourceBasedAnalysisTask {
context as InternalAnalysisContext;
AnalysisCache analysisCache = internalContext.analysisCache;
CacheEntry cacheEntry = internalContext.getCacheEntry(target);
- libraryElement = analysisCache.getValue(target, LIBRARY_ELEMENT1) as LibraryElementImpl;
+ libraryElement = analysisCache.getValue(target, LIBRARY_ELEMENT1)
+ as LibraryElementImpl;
if (libraryElement == null &&
internalContext.aboutToComputeResult(cacheEntry, LIBRARY_ELEMENT1)) {
- libraryElement = analysisCache.getValue(target, LIBRARY_ELEMENT1) as LibraryElementImpl;
+ libraryElement = analysisCache.getValue(target, LIBRARY_ELEMENT1)
+ as LibraryElementImpl;
}
}
//
@@ -5773,7 +5775,7 @@ class ResolveVariableReferencesTask extends SourceBasedAnalysisTask {
// Resolve local variables.
//
RecordingErrorListener errorListener = new RecordingErrorListener();
- Scope nameScope = new LibraryScope(libraryElement, errorListener);
+ Scope nameScope = new LibraryScope(libraryElement);
VariableResolverVisitor visitor = new VariableResolverVisitor(
libraryElement, unitElement.source, typeProvider, errorListener,
nameScope: nameScope);
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/test/generated/element_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698