Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Rebased. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
index a4b53a680fc5f021aa6cff78c68227ce1c505177..bdf7b7b16eaabc13c37be063c0420b913426f731 100644
--- a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
@@ -313,12 +313,12 @@ public:
std::unique_ptr<protocol::Array<protocol::IndexedDB::ObjectStore>> objectStores = protocol::Array<protocol::IndexedDB::ObjectStore>::create();
for (const auto& storeMapEntry : databaseMetadata.objectStores) {
- const IDBObjectStoreMetadata& objectStoreMetadata = storeMapEntry.value;
+ const IDBObjectStoreMetadata& objectStoreMetadata = *storeMapEntry.value;
std::unique_ptr<protocol::Array<protocol::IndexedDB::ObjectStoreIndex>> indexes = protocol::Array<protocol::IndexedDB::ObjectStoreIndex>::create();
for (const auto& metadataMapEntry : objectStoreMetadata.indexes) {
- const IDBIndexMetadata& indexMetadata = metadataMapEntry.value;
+ const IDBIndexMetadata& indexMetadata = *metadataMapEntry.value;
std::unique_ptr<ObjectStoreIndex> objectStoreIndex = ObjectStoreIndex::create()
.setName(indexMetadata.name)
@@ -329,15 +329,15 @@ public:
}
std::unique_ptr<ObjectStore> objectStore = ObjectStore::create()
- .setName(objectStoreMetadata.name)
- .setKeyPath(keyPathFromIDBKeyPath(objectStoreMetadata.keyPath))
- .setAutoIncrement(objectStoreMetadata.autoIncrement)
+ .setName(objectStoreMetadata.own.name)
+ .setKeyPath(keyPathFromIDBKeyPath(objectStoreMetadata.own.keyPath))
+ .setAutoIncrement(objectStoreMetadata.own.autoIncrement)
.setIndexes(std::move(indexes)).build();
objectStores->addItem(std::move(objectStore));
}
std::unique_ptr<DatabaseWithObjectStores> result = DatabaseWithObjectStores::create()
- .setName(databaseMetadata.name)
- .setVersion(databaseMetadata.version)
+ .setName(databaseMetadata.own.name)
+ .setVersion(databaseMetadata.own.version)
.setObjectStores(std::move(objectStores)).build();
m_requestCallback->sendSuccess(std::move(result));

Powered by Google App Engine
This is Rietveld 408576698