Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Rebased. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
index 8bd2ab07ea2a2bbf8142daab88b0d764c5f7bf67..1cd71f230c13f60d5fbea7bda9fcdfb39d264cde 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
@@ -70,8 +70,9 @@ TEST(IDBTransactionTest, EnsureLifetime)
Persistent<IDBDatabase> db = IDBDatabase::create(scope.getExecutionContext(), std::move(backend), FakeIDBDatabaseCallbacks::create());
const int64_t transactionId = 1234;
- const HashSet<String> transactionScope = HashSet<String>();
- Persistent<IDBTransaction> transaction = IDBTransaction::create(scope.getScriptState(), transactionId, transactionScope, WebIDBTransactionModeReadOnly, db.get());
+ HashSet<String> transactionScope = HashSet<String>();
+ transactionScope.add("test-store-name");
+ Persistent<IDBTransaction> transaction = IDBTransaction::createNonVersionChange(scope.getScriptState(), transactionId, transactionScope, WebIDBTransactionModeReadOnly, db.get());
PersistentHeapHashSet<WeakMember<IDBTransaction>> set;
set.add(transaction);
@@ -106,8 +107,9 @@ TEST(IDBTransactionTest, TransactionFinish)
.Times(1);
Persistent<IDBDatabase> db = IDBDatabase::create(scope.getExecutionContext(), std::move(backend), FakeIDBDatabaseCallbacks::create());
- const HashSet<String> transactionScope = HashSet<String>();
- Persistent<IDBTransaction> transaction = IDBTransaction::create(scope.getScriptState(), transactionId, transactionScope, WebIDBTransactionModeReadOnly, db.get());
+ HashSet<String> transactionScope = HashSet<String>();
+ transactionScope.add("test-store-name");
+ Persistent<IDBTransaction> transaction = IDBTransaction::createNonVersionChange(scope.getScriptState(), transactionId, transactionScope, WebIDBTransactionModeReadOnly, db.get());
PersistentHeapHashSet<WeakMember<IDBTransaction>> set;
set.add(transaction);

Powered by Google App Engine
This is Rietveld 408576698