Deprecate HOSTED_NOT_ALLOWED auth error

chrome/browser/signin/signin_error_notifier_ash_unittest.cc

Index: chrome/browser/signin/signin_error_notifier_ash_unittest.cc
diff --git a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
index f880440fd4f22490f7df7ece90ccbd8c0a978261..e485407269ee7d031ea69bf3d1b2a43118bada45 100644
--- a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
@@ -228,7 +228,7 @@ TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {
     { GoogleServiceAuthError::SERVICE_UNAVAILABLE, true },
     { GoogleServiceAuthError::TWO_FACTOR, true },
     { GoogleServiceAuthError::REQUEST_CANCELED, true },
-    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
+    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED_DEPRECATED, true },

[Roger Tawa OOO till Jul 10th, 2016/09/08 13:49:24]

Should remove this from tests.  Same for other signin unit tests.  I understand
that removing from here means the static assert at line 236 now fails, but I
don't think we should be testing a case that can now never happen in production
code.  (The case was removed from unit tests that don't do such a static assert)

We should either remove the assert at line 236, or maybe assert that the number
is GoogleServiceAuthError::NUM_STATES minus number of deprecated values.

[Greg Levin, 2016/09/08 19:56:35]

Done for two of them, but see note in signin_global_error_unittest.cc.

     { GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE, true },
     { GoogleServiceAuthError::SERVICE_ERROR, true },
     { GoogleServiceAuthError::WEB_LOGIN_REQUIRED, true },