Deprecate HOSTED_NOT_ALLOWED auth error

chrome/browser/signin/signin_error_notifier_ash_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_error_notifier_ash.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 210 matching lines @@
     { GoogleServiceAuthError::NONE, false },
     { GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, true },
     { GoogleServiceAuthError::USER_NOT_SIGNED_UP, true },
     { GoogleServiceAuthError::CONNECTION_FAILED, false },
     { GoogleServiceAuthError::CAPTCHA_REQUIRED, true },
     { GoogleServiceAuthError::ACCOUNT_DELETED, true },
     { GoogleServiceAuthError::ACCOUNT_DISABLED, true },
     { GoogleServiceAuthError::SERVICE_UNAVAILABLE, true },
     { GoogleServiceAuthError::TWO_FACTOR, true },
     { GoogleServiceAuthError::REQUEST_CANCELED, true },
-    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
+    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED_DEPRECATED, true },

[Roger Tawa OOO till Jul 10th, 2016/09/08 13:49:24]

Should remove this from tests.  Same for other signin unit tests.  I understand
that removing from here means the static assert at line 236 now fails, but I
don't think we should be testing a case that can now never happen in production
code.  (The case was removed from unit tests that don't do such a static assert)

We should either remove the assert at line 236, or maybe assert that the number
is GoogleServiceAuthError::NUM_STATES minus number of deprecated values.

[Greg Levin, 2016/09/08 19:56:35]

Done for two of them, but see note in signin_global_error_unittest.cc.

     { GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE, true },
     { GoogleServiceAuthError::SERVICE_ERROR, true },
     { GoogleServiceAuthError::WEB_LOGIN_REQUIRED, true },
   };
   static_assert(arraysize(table) == GoogleServiceAuthError::NUM_STATES,
       "table size should match number of auth error types");
 
   for (size_t i = 0; i < arraysize(table); ++i) {
     FakeAuthStatusProvider provider(error_controller_);
     provider.SetAuthError(kTestAccountId,
                           GoogleServiceAuthError(table[i].error_state));
     const Notification* notification = notification_ui_manager_->FindById(
         kNotificationId, NotificationUIManager::GetProfileID(profile_.get()));
     ASSERT_EQ(table[i].is_error, notification != NULL);
     if (table[i].is_error) {
       EXPECT_FALSE(notification->title().empty());
       EXPECT_FALSE(notification->message().empty());
       EXPECT_EQ((size_t)1, notification->buttons().size());
     }
   }
 }
 #endif
 
 }  // namespace test
 }  // namespace ash