Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2314853002: Blacklist renaming of traceImpl method for compatibility with Oilpan plugin. (Closed)

Created:
4 years, 3 months ago by Łukasz Anforowicz
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklist renaming of traceImpl method for compatibility with Oilpan plugin. BUG=643768 Committed: https://crrev.com/71ba89445384ec09c78d0dfce3d92b90da6cc57e Cr-Commit-Position: refs/heads/master@{#416750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
dcheng@, can you take a look please? I've verified that blacklisting renaming of |traceImpl| helps ...
4 years, 3 months ago (2016-09-06 16:03:52 UTC) #2
dcheng
lgtm
4 years, 3 months ago (2016-09-06 19:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314853002/1
4 years, 3 months ago (2016-09-06 20:53:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/230906)
4 years, 3 months ago (2016-09-06 22:55:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314853002/1
4 years, 3 months ago (2016-09-06 22:57:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:04:51 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:06:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71ba89445384ec09c78d0dfce3d92b90da6cc57e
Cr-Commit-Position: refs/heads/master@{#416750}

Powered by Google App Engine
This is Rietveld 408576698