Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2314853002: Blacklist renaming of traceImpl method for compatibility with Oilpan plugin. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 600adeb807171fb69775d72155cf35aa883edac9..6567f77918d8e70960af1cadaeb32abaeafedc7f 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -182,8 +182,8 @@ bool IsBlacklistedMethod(const clang::CXXMethodDecl& decl) {
clang::StringRef name = decl.getName();
// These methods should never be renamed.
- static const char* kBlacklistMethods[] = {"trace", "lock", "unlock",
- "try_lock"};
+ static const char* kBlacklistMethods[] = {"trace", "traceImpl", "lock",
+ "unlock", "try_lock"};
for (const auto& b : kBlacklistMethods) {
if (name == b)
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698