Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 231483002: Mojo: Log an error on the remote message pipe leak condition.[1] (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Log an error on the remote message pipe leak condition.[1] Don't enable the DCHECK, since it blows things up. Note that this doesn't actually fix the bug. Also fix RemoteMessagePipeTest.Multiplex, which is actually currently broken[3]. (Though one might think that MessagePipe's destructor would detect the missing Close()s, one would be wrong: Without closing, the reference cycle wouldn't get broken (by design[4]), so nothing gets destroyed. Oops.) [1] Currently, usually (always?) one side will leak. The problem is that we (only) detach on receiving a kSubtypeMessagePipePeerClosed control message. But then we won't send one of our own.[2] [2] The solution is probably to send an ack for these messages, and detach on receiving the ack instead. This is tricky since you have to handle the case when both sides simultaneously send the peer-closed control message. [3] That is, when this bug is fixed and the DCHECK enabled, the test would still blow up. [4] Possibly a bad design. R=sky@chromium.org BUG=360081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M mojo/system/channel.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-09 18:32:11 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-09 19:14:55 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-09 19:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/231483002/1
6 years, 8 months ago (2014-04-09 19:24:16 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:42:41 UTC) #5
Message was sent while issue was closed.
Change committed as 262803

Powered by Google App Engine
This is Rietveld 408576698