Mojo: Log an error on the remote message pipe leak condition.[1]

mojo/system/channel.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/channel.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
@@ skipping 44 matching lines @@
 }
 
 void Channel::Shutdown() {
   DCHECK(creation_thread_checker_.CalledOnValidThread());
 
   base::AutoLock locker(lock_);
   DCHECK(raw_channel_.get());
   raw_channel_->Shutdown();
   raw_channel_.reset();
 
-  // TODO(vtl): Should I clear |local_id_to_endpoint_info_map_|? Or assert that
-  // it's empty?
+  // This should not occur, but it probably mostly results in leaking;
+  // (Explicitly clearing the |local_id_to_endpoint_info_map_| would likely put
+  // things in an inconsistent state, which is worse. Note that if the map is
+  // nonempty, we probably won't be destroyed, since the endpoints have a
+  // reference to us.)
+  LOG_IF(ERROR, local_id_to_endpoint_info_map_.empty())
+      << "Channel shutting down with endpoints still attached";
+  // TODO(vtl): This currently blows up, but the fix will be nontrivial.
+  // crbug.com/360081
+  //DCHECK(local_id_to_endpoint_info_map_.empty());
 }
 
 MessageInTransit::EndpointId Channel::AttachMessagePipeEndpoint(
     scoped_refptr<MessagePipe> message_pipe, unsigned port) {
   DCHECK(port == 0 || port == 1);
   // Note: This assertion must *not* be done under |lock_|.
   DCHECK_EQ(message_pipe->GetType(port), MessagePipeEndpoint::kTypeProxy);
 
   MessageInTransit::EndpointId local_id;
   {
@@ skipping 206 matching lines @@
   LOG(WARNING) << error_message;
 }
 
 void Channel::HandleLocalError(const base::StringPiece& error_message) {
   // TODO(vtl): Is this how we really want to handle this?
   LOG(WARNING) << error_message;
 }
 
 }  // namespace system
 }  // namespace mojo