Capture wrong states in RawResourceClientStateChecker::responseReceived()

Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960
Committed: https://crrev.com/068bdce3e08bb45e7fdb0b7377787f5946c64ec2
Cr-Commit-Position: refs/heads/master@{#416845}

[hiroshige, 2016-09-06 09:11:18]

Description was changed from

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

BUG=
==========

to

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960
==========

[hiroshige, 2016-09-06 09:11:19]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2016-09-07 01:58:25]

PTAL.

[yhirano, 2016-09-07 02:07:46]

lgtm

https://codereview.chromium.org/2314503003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/RawResource.cpp (right):

https://codereview.chromium.org/2314503003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/RawResource.cpp:310: SECURITY_CHECK(m_state
!= NotifyFinished);
Can you add SECURITY_CHECK(m_state == Started)?

[hiroshige, 2016-09-07 02:10:45]

https://codereview.chromium.org/2314503003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/RawResource.cpp (right):

https://codereview.chromium.org/2314503003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/RawResource.cpp:310: SECURITY_CHECK(m_state
!= NotifyFinished);
On 2016/09/07 02:07:46, yhirano wrote:
> Can you add SECURITY_CHECK(m_state == Started)?

Done.

[hiroshige, 2016-09-07 02:20:28]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-09-07 02:20:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2314503003/#ps20001
(title: "Add SECURITY_CHECK(m_state == Started)")

[commit-bot: I haz the power, 2016-09-07 02:20:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 04:31:32]

Description was changed from

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960
==========

to

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960
==========

[commit-bot: I haz the power, 2016-09-07 04:31:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 04:33:23]

Description was changed from

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960
==========

to

==========
Capture wrong states in RawResourceClientStateChecker::responseReceived()

To investigate in which state RawResourceClientStateChecker::responseReceived()
crashes, this CL adds separate assertions to each of wrong states.
This CL should be reverted at least before going to beta.

BUG=640960

Committed: https://crrev.com/068bdce3e08bb45e7fdb0b7377787f5946c64ec2
Cr-Commit-Position: refs/heads/master@{#416845}
==========

[commit-bot: I haz the power, 2016-09-07 04:33:24]

Patchset 2 (id:??) landed as
https://crrev.com/068bdce3e08bb45e7fdb0b7377787f5946c64ec2
Cr-Commit-Position: refs/heads/master@{#416845}