Capture wrong states in RawResourceClientStateChecker::responseReceived()

third_party/WebKit/Source/core/fetch/RawResource.cpp

 /*
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 281 matching lines @@
     m_state = RedirectBlocked;
 }
 
 NEVER_INLINE void RawResourceClientStateChecker::dataSent()
 {
     SECURITY_CHECK(m_state == Started);
 }
 
 NEVER_INLINE void RawResourceClientStateChecker::responseReceived()
 {
-    // TODO(hiroshige): Temporarily we use DCHECK() here instead of CHECK(),
-    // due to crbug.com/640960.
-    SECURITY_DCHECK(m_state == Started);
+    // TODO(hiroshige): Temporarily we insert the checks below to capture the
+    // wrong state. The checks should be reverted shortly. crbug.com/640960.
+    SECURITY_CHECK(m_state != NotAddedAsClient);
+    SECURITY_CHECK(m_state != RedirectBlocked);
+    SECURITY_CHECK(m_state != ResponseReceived);
+    SECURITY_CHECK(m_state != SetSerializedCachedMetadata);
+    SECURITY_CHECK(m_state != DataReceived);
+    SECURITY_CHECK(m_state != DataDownloaded);
+    SECURITY_CHECK(m_state != NotifyFinished);

[yhirano, 2016/09/07 02:07:46]

Can you add SECURITY_CHECK(m_state == Started)?

[hiroshige, 2016/09/07 02:10:45]

Done.

     m_state = ResponseReceived;
 }
 
 NEVER_INLINE void RawResourceClientStateChecker::setSerializedCachedMetadata()
 {
     SECURITY_CHECK(m_state == ResponseReceived);
     m_state = SetSerializedCachedMetadata;
 }
 
 NEVER_INLINE void RawResourceClientStateChecker::dataReceived()
@@ skipping 10 matching lines @@
 
 NEVER_INLINE void RawResourceClientStateChecker::notifyFinished(Resource* resource)
 {
     SECURITY_CHECK(m_state != NotAddedAsClient);
     SECURITY_CHECK(m_state != NotifyFinished);
     SECURITY_CHECK(resource->errorOccurred() || (m_state == ResponseReceived || m_state == SetSerializedCachedMetadata || m_state == DataReceived || m_state == DataDownloaded));
     m_state = NotifyFinished;
 }
 
 } // namespace blink