third_party/WebKit/Source/core/animation/NonInterpolableValue.h - Issue 2314443002: Code health: Add type checks to CSSLengthInterpolationType::nonInterpolableValuesAreCompatible()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/NonInterpolableValue.h

Issue 2314443002: Code health: Add type checks to CSSLengthInterpolationType::nonInterpolableValuesAreCompatible() (Closed)

Patch Set: Simplify macro Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/NonInterpolableValue.h

diff --git a/third_party/WebKit/Source/core/animation/NonInterpolableValue.h b/third_party/WebKit/Source/core/animation/NonInterpolableValue.h

index 97a7c4f1aaa2a402d5920eb63e089bc7bd285a91..33730bee514a3c4811cf28274111c0e1a466ded3 100644

--- a/third_party/WebKit/Source/core/animation/NonInterpolableValue.h

+++ b/third_party/WebKit/Source/core/animation/NonInterpolableValue.h

@@ -28,7 +28,9 @@ public:

NonInterpolableValue::Type T::staticType = &T::staticType;

#define DEFINE_NON_INTERPOLABLE_VALUE_TYPE_CASTS(T) \

- DEFINE_TYPE_CASTS(T, NonInterpolableValue, value, value->getType() == T::staticType, value.getType() == T::staticType);

+ inline bool is##T(const NonInterpolableValue* value) { return !value || value->getType() == T::staticType; } \

+ DEFINE_TYPE_CASTS(T, NonInterpolableValue, value, is##T(value), is##T(&value));

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('k') | no next file » | no next file with comments »