MacViews: Fix mac_views_browser build linker errors.

MacViews: Fix mac_views_browser build linker errors.

The MacViews browser has been broken since
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499, which removed the
chrome_browser_ui.gypi file, but didn't add the set of files named
"chrome_browser_ui_views_non_mac_sources" back into the mac_views_browser build.
This caused the linking step to fail when mac_views_browser=true.

This change adds those missing files back in.

BUG=644645
TEST=With mac_views_browser=true in args.gn, compile chrome. It should compile
successfully.

[Patti Lor, 2016-09-07 06:37:04]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 06:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 07:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 07:48:35]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2016-09-07 08:04:23]

Description was changed from

==========
MacViews: Fix mac_views_browser build linker errors.

The MacViews browser has been broken since
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499, which removed the
chrome_browser_ui.gypi file, but didn't add the set of files named
"chrome_browser_ui_views_non_mac_sources" back into the mac_views_browser build,
causing the linking step to fail when mac_views_browser=true

This change adds those missing files back in.

TEST=With mac_views_browser=true in args.gn, compile chrome. It should compile
successfully.
==========

to

==========
MacViews: Fix mac_views_browser build linker errors.

The MacViews browser has been broken since
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499, which removed the
chrome_browser_ui.gypi file, but didn't add the set of files named
"chrome_browser_ui_views_non_mac_sources" back into the mac_views_browser build.
This caused the linking step to fail when mac_views_browser=true.

This change adds those missing files back in.

TEST=With mac_views_browser=true in args.gn, compile chrome. It should compile
successfully.
==========

[Patti Lor, 2016-09-07 08:04:42]

patricialor@chromium.org changed reviewers:
+ karandeepb@chromium.org

[Patti Lor, 2016-09-07 08:04:43]

Hi Karan! PTAL :)

[karandeepb, 2016-09-07 08:32:12]

Don't have much context here. LGTM. Please also refer a bug report.

https://codereview.chromium.org/2314353002/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2314353002/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:1831: if (!mac_views_browser) {
If use_aura is true doesn't that imply !mac_views_browser. I am not sure,
asking.

[benwells, 2016-09-07 09:04:04]

Description was changed from

==========
MacViews: Fix mac_views_browser build linker errors.

The MacViews browser has been broken since
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499, which removed the
chrome_browser_ui.gypi file, but didn't add the set of files named
"chrome_browser_ui_views_non_mac_sources" back into the mac_views_browser build.
This caused the linking step to fail when mac_views_browser=true.

This change adds those missing files back in.

TEST=With mac_views_browser=true in args.gn, compile chrome. It should compile
successfully.
==========

to

==========
MacViews: Fix mac_views_browser build linker errors.

The MacViews browser has been broken since
https://crrev.com/eb15fb3a98a5ffdbad048fc7c2afc6763d025499, which removed the
chrome_browser_ui.gypi file, but didn't add the set of files named
"chrome_browser_ui_views_non_mac_sources" back into the mac_views_browser build.
This caused the linking step to fail when mac_views_browser=true.

This change adds those missing files back in.

BUG=644645
TEST=With mac_views_browser=true in args.gn, compile chrome. It should compile
successfully.
==========

[Patti Lor, 2016-09-08 03:58:42]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 03:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2016-09-08 04:00:40]

patricialor@chromium.org changed reviewers:
+ brettw@chromium.org

[Patti Lor, 2016-09-08 04:00:41]

Hi brettw@, PTAL! Thanks.

https://codereview.chromium.org/2314353002/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2314353002/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:1831: if (!mac_views_browser) {
On 2016/09/07 08:32:12, karandeepb wrote:
> If use_aura is true doesn't that imply !mac_views_browser. I am not sure,
> asking. 

That's a good point, I will move this if statement to encompass the
//ui/views/mus dependency being added instead. Thanks!

[commit-bot: I haz the power, 2016-09-08 04:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 04:46:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-09-14 22:49:12]

Sorry, are you still waiting for me for something? It looks like something like
this landed.

[Patti Lor, 2016-09-14 23:19:35]

On 2016/09/14 22:49:12, brettw (ping on IM after 24h) wrote:
> Sorry, are you still waiting for me for something? It looks like something
like
> this landed.

No worries, it's all fine - someone else on my team landed a fix for it first
because they didn't know I put some work in already, so I closed this CL. Sorry
about that!