Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/BUILD.gn

Issue 2314353002: MacViews: Fix mac_views_browser build linker errors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/crypto.gni") 5 import("//build/config/crypto.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//build/split_static_library.gni") 8 import("//build/split_static_library.gni")
9 import("//chrome/common/features.gni") 9 import("//chrome/common/features.gni")
10 import("//media/media_options.gni") 10 import("//media/media_options.gni")
(...skipping 1525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1536 "views/extensions/media_gallery_checkbox_view.cc", 1536 "views/extensions/media_gallery_checkbox_view.cc",
1537 "views/extensions/media_gallery_checkbox_view.h", 1537 "views/extensions/media_gallery_checkbox_view.h",
1538 ] 1538 ]
1539 if (use_aura) { 1539 if (use_aura) {
1540 sources += [ 1540 sources += [
1541 "views/extensions/extension_popup_aura.cc", 1541 "views/extensions/extension_popup_aura.cc",
1542 "views/extensions/extension_popup_aura.h", 1542 "views/extensions/extension_popup_aura.h",
1543 ] 1543 ]
1544 } 1544 }
1545 } 1545 }
1546 if (!is_mac) { 1546 if (!is_mac || mac_views_browser) {
1547 sources += [ 1547 sources += [
1548 # This test header is included because it contains forward declarations 1548 # This test header is included because it contains forward declarations
1549 # needed for "friend" statements for use in tests. 1549 # needed for "friend" statements for use in tests.
1550 "translate/translate_bubble_test_utils.h", 1550 "translate/translate_bubble_test_utils.h",
1551 "views/accessibility/invert_bubble_view.cc", 1551 "views/accessibility/invert_bubble_view.cc",
1552 "views/accessibility/invert_bubble_view.h", 1552 "views/accessibility/invert_bubble_view.h",
1553 "views/autofill/autofill_popup_base_view.cc", 1553 "views/autofill/autofill_popup_base_view.cc",
1554 "views/autofill/autofill_popup_base_view.h", 1554 "views/autofill/autofill_popup_base_view.h",
1555 "views/autofill/autofill_popup_view_views.cc", 1555 "views/autofill/autofill_popup_view_views.cc",
1556 "views/autofill/autofill_popup_view_views.h", 1556 "views/autofill/autofill_popup_view_views.h",
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1820 "views/translate/translate_icon_view.cc", 1820 "views/translate/translate_icon_view.cc",
1821 "views/translate/translate_icon_view.h", 1821 "views/translate/translate_icon_view.h",
1822 "views/update_recommended_message_box.cc", 1822 "views/update_recommended_message_box.cc",
1823 "views/update_recommended_message_box.h", 1823 "views/update_recommended_message_box.h",
1824 "views/validation_message_bubble_view.cc", 1824 "views/validation_message_bubble_view.cc",
1825 "views/validation_message_bubble_view.h", 1825 "views/validation_message_bubble_view.h",
1826 "views/website_settings/chooser_bubble_ui_view.cc", 1826 "views/website_settings/chooser_bubble_ui_view.cc",
1827 "views/website_settings/chooser_bubble_ui_view.h", 1827 "views/website_settings/chooser_bubble_ui_view.h",
1828 "views/website_settings/permission_prompt_impl_views.cc", 1828 "views/website_settings/permission_prompt_impl_views.cc",
1829 ] 1829 ]
1830 if (use_aura) {
1831 deps += [
1832 "//services/ui/public/cpp",
1833 "//services/ui/public/interfaces",
1834 ]
1835 1830
1836 # TODO(erg): These files hard depend on mus, and thus can't be in a gyp 1831 if (!mac_views_browser) {
karandeepb 2016/09/07 08:32:12 If use_aura is true doesn't that imply !mac_views_
Patti Lor 2016/09/08 04:00:41 That's a good point, I will move this if statement
1837 # build. When gyp goes away, merge this back into the sources list. 1832 if (use_aura) {
1838 sources += [ 1833 deps += [
1839 "views/tabs/window_finder_mus.cc", 1834 "//services/ui/public/cpp",
1840 "views/tabs/window_finder_mus.h", 1835 "//services/ui/public/interfaces",
1841 ] 1836 ]
1837
1838 # TODO(erg): These files hard depend on mus, and thus can't be in a gy p
1839 # build. When gyp goes away, merge this back into the sources list.
1840 sources += [
1841 "views/tabs/window_finder_mus.cc",
1842 "views/tabs/window_finder_mus.h",
1843 ]
1844 }
1845 deps += [ "//ui/views/mus" ]
1842 } 1846 }
1843 deps += [ "//ui/views/mus" ]
1844 } 1847 }
1845 if (use_ash) { 1848 if (use_ash) {
1846 sources += [ 1849 sources += [
1847 "views/frame/browser_frame_ash.cc", 1850 "views/frame/browser_frame_ash.cc",
1848 "views/frame/browser_frame_ash.h", 1851 "views/frame/browser_frame_ash.h",
1849 "views/frame/browser_header_painter_ash.cc", 1852 "views/frame/browser_header_painter_ash.cc",
1850 "views/frame/browser_header_painter_ash.h", 1853 "views/frame/browser_header_painter_ash.h",
1851 "views/frame/browser_non_client_frame_view_ash.cc", 1854 "views/frame/browser_non_client_frame_view_ash.cc",
1852 "views/frame/browser_non_client_frame_view_ash.h", 1855 "views/frame/browser_non_client_frame_view_ash.h",
1853 "views/frame/immersive_context_mus.cc", 1856 "views/frame/immersive_context_mus.cc",
(...skipping 1507 matching lines...) Expand 10 before | Expand all | Expand 10 after
3361 "passwords/passwords_model_delegate_mock.cc", 3364 "passwords/passwords_model_delegate_mock.cc",
3362 "passwords/passwords_model_delegate_mock.h", 3365 "passwords/passwords_model_delegate_mock.h",
3363 ] 3366 ]
3364 deps += [ "//chrome/test:test_support_ui" ] 3367 deps += [ "//chrome/test:test_support_ui" ]
3365 } 3368 }
3366 3369
3367 if (enable_extensions) { 3370 if (enable_extensions) {
3368 deps += [ "//extensions/browser" ] 3371 deps += [ "//extensions/browser" ]
3369 } 3372 }
3370 } 3373 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698