Add sessionType and playStoreStatus to chromeosInfoPrivate.

chrome/common/extensions/api/chromeos_info_private.json

Index: chrome/common/extensions/api/chromeos_info_private.json
diff --git a/chrome/common/extensions/api/chromeos_info_private.json b/chrome/common/extensions/api/chromeos_info_private.json
index b87c606903fd8af9fead941799d4494dcebc554f..cdf2d9be2fd19feb3b0563bb0cdd34dd41075fbf 100644
--- a/chrome/common/extensions/api/chromeos_info_private.json
+++ b/chrome/common/extensions/api/chromeos_info_private.json
@@ -28,6 +28,22 @@
                  "a11ySwitchAccessEnabled",
                  "sendFunctionKeys"],
         "description": "Chrome OS system property name"
+      },
+      {
+        "id": "SessionType",
+        "type": "string",
+        "enum": ["normal",

[Devlin, 2016/09/06 23:04:54]

nit: we don't need to line wrap these

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Done.

+                 "kiosk",
+                 "public session"],
+        "description": "Current session type"

[Devlin, 2016/09/06 23:04:53]

Can we describe the different values?

[Rahul Chaturvedi, 2016/09/06 23:19:35]

I am not sure if adding a description here will convey much more than what the
values themselves convey.

[Devlin, 2016/09/07 16:12:28]

What is a "normal" session?  Signed-in?  Not signed in?  Do we document the
meaning and implication of public sessions?  Can we link to that documentation
here?

[Rahul Chaturvedi, 2016/09/07 20:13:23]

Aren't these things that we'd typically put in API documentation? It seems a bit
excessive to give someone that much context with just this description.

Considering this is currently a private API and hence we don't have any
documentation for it, if someone does not actually understand these concepts,
they really should not be using this API.

[Devlin, 2016/09/07 20:23:27]

This is the API documentation. :)  If we want to hold off on more documentation
for this for now, that's fine, but we'll probably need to add it at some point.

+      },
+      {
+        "id": "PlayStoreStatus",
+        "type": "string",
+        "enum": ["not available",

[Devlin, 2016/09/06 23:04:53]

ditto re line wrapping

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Done.

+                 "available",
+                 "enabled"],
+        "description": "Status of the play store"

[Devlin, 2016/09/06 23:04:53]

ditto - esp given "available" and "enabled" sound very similar to me.

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Clarified the difference between available and enabled. The rest of the names
are pretty self-descriptive.

[Devlin, 2016/09/07 16:12:28]

What is the play store in this context?  Why wouldn't it be available?  When
would it be enabled but not available?

[Rahul Chaturvedi, 2016/09/07 20:13:23]

Same explanation as above.

       }
     ],
     "functions": [
@@ -57,6 +73,8 @@
                   "hwid": {"type": "string", "optional": true, "description": "Hardware ID"},
                   "initialLocale" : {"type": "string", "optional": true, "description": "Initial locale for the device"},
                   "isOwner" : {"type": "boolean", "optional": true, "description": "True if current logged in user is device owner"},
+                  "sessionType": {"$ref": "SessionType", "optional": true},
+                  "playStoreStatus": {"$ref": "PlayStoreStatus", "optional": true},
                   "clientId" : {"type": "string", "optional": true, "description": "Device client id"},
                   "timezone" : {"type": "string", "optional": true, "description": "Timezone"},
                   "a11yLargeCursorEnabled" : {"type": "boolean", "optional": true, "description": "If true, ChromeOS is showing enlarged cursor."},