Add sessionType and playStoreStatus to chromeosInfoPrivate.

chrome/common/extensions/api/chromeos_info_private.json

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [
   {
     "namespace": "chromeosInfoPrivate",
     "description": "none",
     "compiler_options": {
       "implemented_in": "chrome/browser/chromeos/extensions/info_private_api.h"
@@ skipping 10 matching lines @@
                  "a11yScreenMagnifierEnabled",
                  "a11yAutoClickEnabled",
                  "a11yVirtualKeyboardEnabled",
                  "a11yCaretHighlightEnabled",
                  "a11yCursorHighlightEnabled",
                  "a11yFocusHighlightEnabled",
                  "a11ySelectToSpeakEnabled",
                  "a11ySwitchAccessEnabled",
                  "sendFunctionKeys"],
         "description": "Chrome OS system property name"
+      },
+      {
+        "id": "SessionType",
+        "type": "string",
+        "enum": ["normal",

[Devlin, 2016/09/06 23:04:54]

nit: we don't need to line wrap these

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Done.

+                 "kiosk",
+                 "public session"],
+        "description": "Current session type"

[Devlin, 2016/09/06 23:04:53]

Can we describe the different values?

[Rahul Chaturvedi, 2016/09/06 23:19:35]

I am not sure if adding a description here will convey much more than what the
values themselves convey.

[Devlin, 2016/09/07 16:12:28]

What is a "normal" session?  Signed-in?  Not signed in?  Do we document the
meaning and implication of public sessions?  Can we link to that documentation
here?

[Rahul Chaturvedi, 2016/09/07 20:13:23]

Aren't these things that we'd typically put in API documentation? It seems a bit
excessive to give someone that much context with just this description.

Considering this is currently a private API and hence we don't have any
documentation for it, if someone does not actually understand these concepts,
they really should not be using this API.

[Devlin, 2016/09/07 20:23:27]

This is the API documentation. :)  If we want to hold off on more documentation
for this for now, that's fine, but we'll probably need to add it at some point.

+      },
+      {
+        "id": "PlayStoreStatus",
+        "type": "string",
+        "enum": ["not available",

[Devlin, 2016/09/06 23:04:53]

ditto re line wrapping

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Done.

+                 "available",
+                 "enabled"],
+        "description": "Status of the play store"

[Devlin, 2016/09/06 23:04:53]

ditto - esp given "available" and "enabled" sound very similar to me.

[Rahul Chaturvedi, 2016/09/06 23:19:35]

Clarified the difference between available and enabled. The rest of the names
are pretty self-descriptive.

[Devlin, 2016/09/07 16:12:28]

What is the play store in this context?  Why wouldn't it be available?  When
would it be enabled but not available?

[Rahul Chaturvedi, 2016/09/07 20:13:23]

Same explanation as above.

       }
     ],
     "functions": [
       {
         "name": "get",
         "description": "Fetches customization values for the given property names. See property names in the declaration of the returned dictionary.",
         "type": "function",
         "parameters": [
           {
             "name": "propertyNames",
             "type": "array",
             "description": "Chrome OS Property names",
             "items": {"type": "string"}
           },
           {
             "name": "callback",
             "type": "function",
             "parameters": [
               {
                 "name": "propertiesDictionary",
                 "type": "object",
                 "description": "Dictionary which contains all requested properties",
                 "properties": {
                   "board" : {"type": "string", "optional": true, "description": "Board name"},
                   "customizationId": {"type": "string", "optional": true, "description": "Customization ID"},
                   "homeProvider" : {"type": "string", "optional": true, "description": "Home provider which is used by the cellular device"},
                   "hwid": {"type": "string", "optional": true, "description": "Hardware ID"},
                   "initialLocale" : {"type": "string", "optional": true, "description": "Initial locale for the device"},
                   "isOwner" : {"type": "boolean", "optional": true, "description": "True if current logged in user is device owner"},
+                  "sessionType": {"$ref": "SessionType", "optional": true},
+                  "playStoreStatus": {"$ref": "PlayStoreStatus", "optional": true},
                   "clientId" : {"type": "string", "optional": true, "description": "Device client id"},
                   "timezone" : {"type": "string", "optional": true, "description": "Timezone"},
                   "a11yLargeCursorEnabled" : {"type": "boolean", "optional": true, "description": "If true, ChromeOS is showing enlarged cursor."},
                   "a11yStickyKeysEnabled" : {"type": "boolean", "optional": true, "description": "If true, sticky keys are turned on."},
                   "a11ySpokenFeedbackEnabled" : {"type": "boolean", "optional": true, "description": "If enabled, ChromeOS text-to-speech feature is turned on."},
                   "a11yHighContrastEnabled" : {"type": "boolean", "optional": true, "description": "If true, all displays have high contrast mode turned on."},
                   "a11yScreenMagnifierEnabled" : {"type": "boolean", "optional": true, "description": "If true, all displays have screen magnifier turned on."},
                   "a11yAutoClickEnabled" : {"type": "boolean", "optional": true, "description": "If true, auto mouse click accessibility feature is turned on."},
                   "a11yVirtualKeyboardEnabled" : {"type": "boolean", "optional": true, "description": "If true, virtual keyboard will be enabled."},
                   "sendFunctionKeys" : {"type": "boolean", "optional": true, "description": "If true, the ChromeOS top row keys send function keys."},
@@ skipping 25 matching lines @@
           {
             "name": "propertyValue",
             "type": "any",
             "description": "Chrome OS system property value"
           }
         ]
       }
     ]
   }
 ]