Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 23143007: Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them." (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
titzer, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them." This reverts commit r16232 for breaking the tools/gen-postmortem-metadata.py script. Will reland without the objects.{cc,h} changes. TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2049 lines, -2226 lines) Patch
M src/arm/lithium-arm.h View 143 chunks +212 lines, -231 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 14 chunks +40 lines, -52 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 100 chunks +226 lines, -244 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen.h View 23 chunks +38 lines, -45 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 254 chunks +594 lines, -609 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 15 chunks +43 lines, -57 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 149 chunks +213 lines, -232 lines 0 comments Download
M src/lithium.h View 15 chunks +15 lines, -15 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 14 chunks +40 lines, -52 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 141 chunks +207 lines, -226 lines 0 comments Download
M src/objects.h View 131 chunks +132 lines, -140 lines 0 comments Download
M src/objects.cc View 20 chunks +21 lines, -21 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 13 chunks +37 lines, -49 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 140 chunks +209 lines, -230 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r16243.
7 years, 4 months ago (2013-08-20 10:52:47 UTC) #1
titzer
On 2013/08/20 10:52:47, Benedikt Meurer wrote: > Committed patchset #1 manually as r16243. I do ...
7 years, 4 months ago (2013-08-21 14:40:23 UTC) #2
Benedikt Meurer
What would you suggest to do instead?
7 years, 4 months ago (2013-08-21 19:03:23 UTC) #3
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-08-21 19:20:00 UTC) #4
Message was sent while issue was closed.
On 2013/08/21 19:03:23, Benedikt Meurer wrote:
> What would you suggest to do instead?

Indeed this is a revert of an earlier change that broke the build.  Ben, maybe
you complain about the original change?

Powered by Google App Engine
This is Rietveld 408576698