Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: src/arm/lithium-codegen-arm.h

Issue 23143007: Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 25 matching lines...) Expand all
36 #include "scopes.h" 36 #include "scopes.h"
37 #include "v8utils.h" 37 #include "v8utils.h"
38 38
39 namespace v8 { 39 namespace v8 {
40 namespace internal { 40 namespace internal {
41 41
42 // Forward declarations. 42 // Forward declarations.
43 class LDeferredCode; 43 class LDeferredCode;
44 class SafepointGenerator; 44 class SafepointGenerator;
45 45
46 class LCodeGen V8_FINAL BASE_EMBEDDED { 46 class LCodeGen BASE_EMBEDDED {
47 public: 47 public:
48 LCodeGen(LChunk* chunk, MacroAssembler* assembler, CompilationInfo* info) 48 LCodeGen(LChunk* chunk, MacroAssembler* assembler, CompilationInfo* info)
49 : zone_(info->zone()), 49 : zone_(info->zone()),
50 chunk_(static_cast<LPlatformChunk*>(chunk)), 50 chunk_(static_cast<LPlatformChunk*>(chunk)),
51 masm_(assembler), 51 masm_(assembler),
52 info_(info), 52 info_(info),
53 current_block_(-1), 53 current_block_(-1),
54 current_instruction_(-1), 54 current_instruction_(-1),
55 instructions_(chunk->instructions()), 55 instructions_(chunk->instructions()),
56 deoptimizations_(4, info->zone()), 56 deoptimizations_(4, info->zone()),
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 // itself is emitted at the end of the generated code. 413 // itself is emitted at the end of the generated code.
414 SafepointTableBuilder safepoints_; 414 SafepointTableBuilder safepoints_;
415 415
416 // Compiler from a set of parallel moves to a sequential list of moves. 416 // Compiler from a set of parallel moves to a sequential list of moves.
417 LGapResolver resolver_; 417 LGapResolver resolver_;
418 418
419 Safepoint::Kind expected_safepoint_kind_; 419 Safepoint::Kind expected_safepoint_kind_;
420 420
421 int old_position_; 421 int old_position_;
422 422
423 class PushSafepointRegistersScope V8_FINAL BASE_EMBEDDED { 423 class PushSafepointRegistersScope BASE_EMBEDDED {
424 public: 424 public:
425 PushSafepointRegistersScope(LCodeGen* codegen, 425 PushSafepointRegistersScope(LCodeGen* codegen,
426 Safepoint::Kind kind) 426 Safepoint::Kind kind)
427 : codegen_(codegen) { 427 : codegen_(codegen) {
428 ASSERT(codegen_->info()->is_calling()); 428 ASSERT(codegen_->info()->is_calling());
429 ASSERT(codegen_->expected_safepoint_kind_ == Safepoint::kSimple); 429 ASSERT(codegen_->expected_safepoint_kind_ == Safepoint::kSimple);
430 codegen_->expected_safepoint_kind_ = kind; 430 codegen_->expected_safepoint_kind_ = kind;
431 431
432 switch (codegen_->expected_safepoint_kind_) { 432 switch (codegen_->expected_safepoint_kind_) {
433 case Safepoint::kWithRegisters: 433 case Safepoint::kWithRegisters:
(...skipping 27 matching lines...) Expand all
461 LCodeGen* codegen_; 461 LCodeGen* codegen_;
462 }; 462 };
463 463
464 friend class LDeferredCode; 464 friend class LDeferredCode;
465 friend class LEnvironment; 465 friend class LEnvironment;
466 friend class SafepointGenerator; 466 friend class SafepointGenerator;
467 DISALLOW_COPY_AND_ASSIGN(LCodeGen); 467 DISALLOW_COPY_AND_ASSIGN(LCodeGen);
468 }; 468 };
469 469
470 470
471 class LDeferredCode : public ZoneObject { 471 class LDeferredCode: public ZoneObject {
472 public: 472 public:
473 explicit LDeferredCode(LCodeGen* codegen) 473 explicit LDeferredCode(LCodeGen* codegen)
474 : codegen_(codegen), 474 : codegen_(codegen),
475 external_exit_(NULL), 475 external_exit_(NULL),
476 instruction_index_(codegen->current_instruction_) { 476 instruction_index_(codegen->current_instruction_) {
477 codegen->AddDeferredCode(this); 477 codegen->AddDeferredCode(this);
478 } 478 }
479 479
480 virtual ~LDeferredCode() {} 480 virtual ~LDeferredCode() { }
481 virtual void Generate() = 0; 481 virtual void Generate() = 0;
482 virtual LInstruction* instr() = 0; 482 virtual LInstruction* instr() = 0;
483 483
484 void SetExit(Label* exit) { external_exit_ = exit; } 484 void SetExit(Label* exit) { external_exit_ = exit; }
485 Label* entry() { return &entry_; } 485 Label* entry() { return &entry_; }
486 Label* exit() { return external_exit_ != NULL ? external_exit_ : &exit_; } 486 Label* exit() { return external_exit_ != NULL ? external_exit_ : &exit_; }
487 int instruction_index() const { return instruction_index_; } 487 int instruction_index() const { return instruction_index_; }
488 488
489 protected: 489 protected:
490 LCodeGen* codegen() const { return codegen_; } 490 LCodeGen* codegen() const { return codegen_; }
491 MacroAssembler* masm() const { return codegen_->masm(); } 491 MacroAssembler* masm() const { return codegen_->masm(); }
492 492
493 private: 493 private:
494 LCodeGen* codegen_; 494 LCodeGen* codegen_;
495 Label entry_; 495 Label entry_;
496 Label exit_; 496 Label exit_;
497 Label* external_exit_; 497 Label* external_exit_;
498 int instruction_index_; 498 int instruction_index_;
499 }; 499 };
500 500
501 } } // namespace v8::internal 501 } } // namespace v8::internal
502 502
503 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_ 503 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698