[Download Home] Don't show canceled downloads

[Download Home] Don't show canceled downloads

Explicitly check for a "completed" state.

BUG=616324, 644485
Committed: https://crrev.com/2914dca6fb5502de404912547f21be813b4fab4d
Cr-Commit-Position: refs/heads/master@{#416791}

[gone, 2016-09-06 22:34:01]

dfalcantara@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-09-06 23:08:55]

lgtm % comment

https://codereview.chromium.org/2314223003/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_manager_service.cc (right):

https://codereview.chromium.org/2314223003/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_manager_service.cc:246: ||
item->GetState() != content::DownloadItem::DownloadState::COMPLETE) {
the 2nd condition implies the first one, you can remove the first one

[gone, 2016-09-06 23:24:05]

https://codereview.chromium.org/2314223003/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_manager_service.cc (right):

https://codereview.chromium.org/2314223003/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_manager_service.cc:246: ||
item->GetState() != content::DownloadItem::DownloadState::COMPLETE) {
On 2016/09/06 23:08:55, qinmin wrote:
> the 2nd condition implies the first one, you can remove the first one

Done.

[gone, 2016-09-06 23:24:19]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-06 23:24:19]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2314223003/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-09-06 23:24:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 00:19:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 00:21:30]

Description was changed from

==========
[Download Home] Don't show canceled downloads

Explicitly check for a "completed" state.

BUG=616324,644485
==========

to

==========
[Download Home] Don't show canceled downloads

Explicitly check for a "completed" state.

BUG=616324,644485

Committed: https://crrev.com/2914dca6fb5502de404912547f21be813b4fab4d
Cr-Commit-Position: refs/heads/master@{#416791}
==========

[commit-bot: I haz the power, 2016-09-07 00:21:31]

Patchset 2 (id:??) landed as
https://crrev.com/2914dca6fb5502de404912547f21be813b4fab4d
Cr-Commit-Position: refs/heads/master@{#416791}