[Download Home] Don't show canceled downloads

chrome/browser/android/download/download_manager_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/download/download_manager_service.h"
 
 #include "base/android/jni_string.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 220 matching lines @@
   }
   pending_actions_.clear();
 
   // Monitor all DownloadItems for changes.
   updateNotifier(this, GetDownloadManager(false), original_notifier_);
   updateNotifier(this, GetDownloadManager(true), off_the_record_notifier_);
 }
 
 void DownloadManagerService::OnDownloadUpdated(
     content::DownloadManager* manager, content::DownloadItem* item) {
+  if (java_ref_.is_null())
+    return;
+
   // Ignore anything that isn't a completed download notification.
-  if (!item->IsDone() || java_ref_.is_null())
+  if (!item->IsDone()
+      || item->GetState() != content::DownloadItem::DownloadState::COMPLETE) {

[qinmin, 2016/09/06 23:08:55]

the 2nd condition implies the first one, you can remove the first one

[gone, 2016/09/06 23:24:05]

Done.

     return;
+  }
 
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_DownloadManagerService_onDownloadItemUpdated(
       env,
       java_ref_.obj(),
       ConvertUTF8ToJavaString(env, item->GetGuid()).obj(),
       ConvertUTF8ToJavaString(
           env, item->GetFileNameToReportUser().value()).obj(),
       ConvertUTF8ToJavaString(
           env, item->GetTargetFilePath().value()).obj(),
@@ skipping 135 matching lines @@
   content::DownloadManager* manager =
       content::BrowserContext::GetDownloadManager(profile);
 
   // Update notifiers to monitor any newly created DownloadManagers.
   updateNotifier(
       this, manager,
       is_off_the_record ? off_the_record_notifier_ : original_notifier_);
 
   return manager;
 }