Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2314203002: Move DisplayList to display; add ScreenBase. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DisplayList to display; add ScreenBase. Move DisplayList class to ui/display, display namespace. Rename existing 'DisplayList' vector alias to 'Displays'. Add ScreenBase class with some basic functionality. Not strictly necessary; but seems beneficial. ( helps codereview.chromium.org/2302673002 ) BUG=NONE TEST=Compiles; automated tests; no behavior changes. R=oshima@chromium.org,sky@chromium.org Committed: https://crrev.com/5e048a75f9436f93b86202df7dbf76f52cd992b0 Cr-Commit-Position: refs/heads/master@{#417014}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update unit test namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -565 lines) Patch
M ash/display/display_manager.h View 6 chunks +8 lines, -8 lines 0 comments Download
M ash/display/display_manager.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ash/display/unified_mouse_warp_controller.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/mus/test/wm_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/test/wm_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/test/wm_test_screen.h View 1 chunk +3 lines, -20 lines 0 comments Download
M ash/mus/test/wm_test_screen.cc View 2 chunks +3 lines, -56 lines 0 comments Download
M ash/mus/window_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
A + ui/display/display_list.h View 2 chunks +7 lines, -10 lines 0 comments Download
A + ui/display/display_list.cc View 3 chunks +5 lines, -6 lines 0 comments Download
A + ui/display/display_list_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/manager/display_layout.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/manager/display_layout.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/manager/display_layout_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/display/manager/display_manager_utilities.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/manager/display_manager_utilities.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/screen_base.h View 2 chunks +21 lines, -17 lines 0 comments Download
A ui/display/screen_base.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D ui/views/mus/display_list.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/views/mus/display_list.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D ui/views/mus/display_list_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M ui/views/mus/screen_mus.h View 4 chunks +2 lines, -25 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 6 chunks +13 lines, -79 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
msw
Hey Scott and Oshima, please take a look; thanks! Oshima: ui/display/* Scott: everything else (ash/*, ...
4 years, 3 months ago (2016-09-06 20:14:27 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-06 21:28:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314203002/20001
4 years, 3 months ago (2016-09-07 18:49:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 18:55:52 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:57:55 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e048a75f9436f93b86202df7dbf76f52cd992b0
Cr-Commit-Position: refs/heads/master@{#417014}

Powered by Google App Engine
This is Rietveld 408576698