Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2314093002: Revert of Make a pen in eraser mode visible thru PointerEvent.buttons (Closed)

Created:
4 years, 3 months ago by mustaq
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Make a pen in eraser mode visible thru PointerEvent.buttons (patchset #1 id:1 of https://codereview.chromium.org/2313653004/ ) Reason for revert: Broke the build. Original issue's description: > Make a pen in eraser mode visible thru PointerEvent.buttons > > The PointerEvent spec can't gracefully support a hovering pen in eraser > mode because a non-zero |buttons| field indicate an active buttons > state. The issue is currently being discussed in github: > https://github.com/w3c/pointerevents/issues/134 > > Until the spec gets fixed, this CL exposes the eraser mode in a > spec-compliant way by hiding the eraser mode until the pen touches the > digitizer. Edge shows the same behavior. > > This CL also adds X1, X2 & Eraser button/buttons values to > WebPointerProperties. > > BUG=642455 > > Review-Url: https://codereview.chromium.org/2296303002 > Cr-Commit-Position: refs/heads/master@{#416360} > (cherry picked from commit 758b11555d5e65c63258731d4fc72b7d7edea0d7) > > Committed: https://chromium.googlesource.com/chromium/src/+/956dc72f92984d993e390491c90b283beda8b89c TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -358 lines) Patch
M components/test_runner/event_sender.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html View 5 chunks +25 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 2 chunks +1 line, -255 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 4 chunks +10 lines, -31 lines 0 comments Download
M third_party/WebKit/public/platform/WebPointerProperties.h View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mustaq
Created Revert of Make a pen in eraser mode visible thru PointerEvent.buttons
4 years, 3 months ago (2016-09-06 16:07:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314093002/1
4 years, 3 months ago (2016-09-06 16:07:34 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:08:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698