Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: components/test_runner/event_sender.cc

Issue 2314093002: Revert of Make a pen in eraser mode visible thru PointerEvent.buttons (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/test_runner/event_sender.h" 5 #include "components/test_runner/event_sender.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 using blink::WebTouchEvent; 56 using blink::WebTouchEvent;
57 using blink::WebTouchPoint; 57 using blink::WebTouchPoint;
58 using blink::WebVector; 58 using blink::WebVector;
59 using blink::WebView; 59 using blink::WebView;
60 60
61 namespace test_runner { 61 namespace test_runner {
62 62
63 namespace { 63 namespace {
64 64
65 const int kRawMousePointerId = -1; 65 const int kRawMousePointerId = -1;
66 const char* const kPointerTypeStringUnknown = ""; 66 const char* kPointerTypeStringUnknown = "";
67 const char* const kPointerTypeStringMouse = "mouse"; 67 const char* kPointerTypeStringMouse = "mouse";
68 const char* const kPointerTypeStringTouch = "touch"; 68 const char* kPointerTypeStringPen = "pen";
69 const char* const kPointerTypeStringPen = "pen"; 69 const char* kPointerTypeStringTouch = "touch";
70 const char* const kPointerTypeStringEraser = "eraser";
71 70
72 // Assigns |pointerType| from the provided |args|. Returns false if there was 71 // Assigns |pointerType| from the provided |args|. Returns false if there was
73 // any error. 72 // any error.
74 bool getPointerType(gin::Arguments* args, 73 bool getPointerType(gin::Arguments* args,
75 bool isOnlyMouseAndPenAllowed, 74 bool isOnlyMouseAndPenAllowed,
76 WebPointerProperties::PointerType& pointerType) { 75 WebPointerProperties::PointerType& pointerType) {
77 if (args->PeekNext().IsEmpty()) 76 if (args->PeekNext().IsEmpty())
78 return true; 77 return true;
79 std::string pointer_type_string; 78 std::string pointer_type_string;
80 if (!args->GetNext(&pointer_type_string)) { 79 if (!args->GetNext(&pointer_type_string)) {
81 args->ThrowError(); 80 args->ThrowError();
82 return false; 81 return false;
83 } 82 }
84 if (isOnlyMouseAndPenAllowed && 83 if (isOnlyMouseAndPenAllowed &&
85 (pointer_type_string == kPointerTypeStringUnknown || 84 (pointer_type_string == kPointerTypeStringUnknown ||
86 pointer_type_string == kPointerTypeStringTouch)) { 85 pointer_type_string == kPointerTypeStringTouch)) {
87 args->ThrowError(); 86 args->ThrowError();
88 return false; 87 return false;
89 } 88 }
90 if (pointer_type_string == kPointerTypeStringUnknown) { 89 if (pointer_type_string == kPointerTypeStringUnknown) {
91 pointerType = WebMouseEvent::PointerType::Unknown; 90 pointerType = WebMouseEvent::PointerType::Unknown;
92 } else if (pointer_type_string == kPointerTypeStringMouse) { 91 } else if (pointer_type_string == kPointerTypeStringMouse) {
93 pointerType = WebMouseEvent::PointerType::Mouse; 92 pointerType = WebMouseEvent::PointerType::Mouse;
93 } else if (pointer_type_string == kPointerTypeStringPen) {
94 pointerType = WebMouseEvent::PointerType::Pen;
94 } else if (pointer_type_string == kPointerTypeStringTouch) { 95 } else if (pointer_type_string == kPointerTypeStringTouch) {
95 pointerType = WebMouseEvent::PointerType::Touch; 96 pointerType = WebMouseEvent::PointerType::Touch;
96 } else if (pointer_type_string == kPointerTypeStringPen) {
97 pointerType = WebMouseEvent::PointerType::Pen;
98 } else if (pointer_type_string == kPointerTypeStringEraser) {
99 pointerType = WebMouseEvent::PointerType::Eraser;
100 } else { 97 } else {
101 args->ThrowError(); 98 args->ThrowError();
102 return false; 99 return false;
103 } 100 }
104 return true; 101 return true;
105 } 102 }
106 103
107 // Parses |pointerType|, |rawPointerId|, |pressure|, |tiltX| and |tiltY| from 104 // Parses |pointerType|, |rawPointerId|, |pressure|, |tiltX| and |tiltY| from
108 // the provided |args|. Returns false if there was any error, assuming the last 105 // the provided |args|. Returns false if there was any error, assuming the last
109 // 3 of the five parsed parameters are optional. 106 // 3 of the five parsed parameters are optional.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 int GetWebMouseEventModifierForButton(WebMouseEvent::Button button) { 168 int GetWebMouseEventModifierForButton(WebMouseEvent::Button button) {
172 switch (button) { 169 switch (button) {
173 case WebMouseEvent::Button::NoButton: 170 case WebMouseEvent::Button::NoButton:
174 return 0; 171 return 0;
175 case WebMouseEvent::Button::Left: 172 case WebMouseEvent::Button::Left:
176 return WebMouseEvent::LeftButtonDown; 173 return WebMouseEvent::LeftButtonDown;
177 case WebMouseEvent::Button::Middle: 174 case WebMouseEvent::Button::Middle:
178 return WebMouseEvent::MiddleButtonDown; 175 return WebMouseEvent::MiddleButtonDown;
179 case WebMouseEvent::Button::Right: 176 case WebMouseEvent::Button::Right:
180 return WebMouseEvent::RightButtonDown; 177 return WebMouseEvent::RightButtonDown;
181 case WebPointerProperties::Button::X1:
182 case WebPointerProperties::Button::X2:
183 case WebPointerProperties::Button::Eraser:
184 return 0; // Not implemented yet
185 } 178 }
186 NOTREACHED(); 179 NOTREACHED();
187 return 0; 180 return 0;
188 } 181 }
189 182
190 const int kButtonsInModifiers = WebMouseEvent::LeftButtonDown 183 const int kButtonsInModifiers = WebMouseEvent::LeftButtonDown
191 | WebMouseEvent::MiddleButtonDown | WebMouseEvent::RightButtonDown; 184 | WebMouseEvent::MiddleButtonDown | WebMouseEvent::RightButtonDown;
192 185
193 int modifiersWithButtons(int modifiers, int buttons) { 186 int modifiersWithButtons(int modifiers, int buttons) {
194 return (modifiers & ~kButtonsInModifiers) 187 return (modifiers & ~kButtonsInModifiers)
(...skipping 2683 matching lines...) Expand 10 before | Expand all | Expand 10 after
2878 } 2871 }
2879 2872
2880 std::unique_ptr<WebInputEvent> EventSender::ScaleEvent( 2873 std::unique_ptr<WebInputEvent> EventSender::ScaleEvent(
2881 const WebInputEvent& event) { 2874 const WebInputEvent& event) {
2882 // ui::ScaleWebInputEvent returns nullptr when the scale is 1.0f as the event 2875 // ui::ScaleWebInputEvent returns nullptr when the scale is 1.0f as the event
2883 // does not have to be converted. 2876 // does not have to be converted.
2884 return ui::ScaleWebInputEvent(event, delegate()->GetWindowToViewportScale()); 2877 return ui::ScaleWebInputEvent(event, delegate()->GetWindowToViewportScale());
2885 } 2878 }
2886 2879
2887 } // namespace test_runner 2880 } // namespace test_runner
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698