Chromium Code Reviews| Index: net/server/http_server.h |
| diff --git a/net/server/http_server.h b/net/server/http_server.h |
| index a0062d6821bc30f8129e590e31ef03bf0563aa84..2384670749c3519346d87c80a1091d2c39376a99 100644 |
| --- a/net/server/http_server.h |
| +++ b/net/server/http_server.h |
| @@ -98,8 +98,9 @@ class HttpServer { |
| // Expects the raw data to be stored in recv_data_. If parsing is successful, |
| // will remove the data parsed from recv_data_, leaving only the unused |
| - // recv data. |
| - bool ParseHeaders(const char* data, |
| + // recv data. If parsing fails, the connection will be closed. |
|
mmenke
2016/09/12 20:35:04
Here's my suggestion: Return false on error, leav
slan
2016/09/14 15:50:57
Done.
|
| + bool ParseHeaders(int connection_id, |
| + const char* data, |
| size_t data_len, |
| HttpServerRequestInfo* info, |
| size_t* pos); |