Handle non-HTTP/1.1 requests more gracefully in net::HttpServer.

net/server/http_server.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SERVER_HTTP_SERVER_H_
 #define NET_SERVER_HTTP_SERVER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 80 matching lines @@
   void DoReadLoop(HttpConnection* connection);
   void OnReadCompleted(int connection_id, int rv);
   int HandleReadResult(HttpConnection* connection, int rv);
 
   void DoWriteLoop(HttpConnection* connection);
   void OnWriteCompleted(int connection_id, int rv);
   int HandleWriteResult(HttpConnection* connection, int rv);
 
   // Expects the raw data to be stored in recv_data_. If parsing is successful,
   // will remove the data parsed from recv_data_, leaving only the unused
-  // recv data.
-  bool ParseHeaders(const char* data,
+  // recv data. If parsing fails, the connection will be closed.

[mmenke, 2016/09/12 20:35:04]

Here's my suggestion:  Return false on error, leave *pos as 0 when we haven't
reached the end of the headers yet.  Hrm...the HTTP header parsing code
state-machine is ugly.  :(

[slan, 2016/09/14 15:50:57]

Done.

+  bool ParseHeaders(int connection_id,
+                    const char* data,
                     size_t data_len,
                     HttpServerRequestInfo* info,
                     size_t* pos);
 
   HttpConnection* FindConnection(int connection_id);
 
   // Whether or not Close() has been called during delegate callback processing.
   bool HasClosedConnection(HttpConnection* connection);
 
   const std::unique_ptr<ServerSocket> server_socket_;
   std::unique_ptr<StreamSocket> accepted_socket_;
   HttpServer::Delegate* const delegate_;
 
   int last_id_;
   IdToConnectionMap id_to_connection_;
 
   base::WeakPtrFactory<HttpServer> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpServer);
 };
 
 }  // namespace net
 
 #endif // NET_SERVER_HTTP_SERVER_H_