Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Index: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a1b993b68454009a76c98328a4ee4f19769e6876
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
@@ -0,0 +1,27 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(PasswordManagerTest, IsDomainNameMonitoredTest) {
+  std::string domain_name;
+
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.linkedin.com");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.amazon.com");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "https://www.facebook.com");
+  EXPECT_TRUE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "http://wikipedia.org");
+  EXPECT_FALSE(domain_name.empty());
+  domain_name = password_manager_metrics_util::IsDomainNameMonitored(
+      "http://thisisnotwikipedia.org");
+  EXPECT_TRUE(domain_name.empty());
+}

[Ilya Sherman, 2013/09/10 22:30:54]

If you keep the bucketization strategy you've implemented here, please add some
test coverage to verify that it is working correctly, if possible.  This might
mean you need to mock out the source of randomness somehow for testing, since
it's fairly important to test that (a) a single website can land in multiple
buckets and (b) a single website can't land in too many different buckets and
(c) buckets are "equally weighted" in some sense.

[jdomingos, 2013/09/11 15:50:30]

Hi Ilya,

The points (a) and (c), depend on the random value generation therefore I am
wondering if we really need these tests.