chrome/browser/password_manager/password_manager_metrics_util_unittest.cc - Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review 6 Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_metrics_util.cc ('K') | « chrome/browser/password_manager/password_manager_metrics_util.cc ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | chrome/browser/password_manager/password_manager_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/password_manager/password_manager_metrics_util.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 TEST(PasswordManagerTest, IsDomainNameMonitoredTest) {

	10 std::string domain_name;

	11

	12 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	13 "https://www.linkedin.com");

	14 EXPECT_FALSE(domain_name.empty());

	15 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	16 "https://www.amazon.com");

	17 EXPECT_FALSE(domain_name.empty());

	18 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	19 "https://www.facebook.com");

	20 EXPECT_TRUE(domain_name.empty());

	21 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	22 "http://wikipedia.org");

	23 EXPECT_FALSE(domain_name.empty());

	24 domain_name = password_manager_metrics_util::IsDomainNameMonitored(

	25 "http://thisisnotwikipedia.org");

	26 EXPECT_TRUE(domain_name.empty());

	27 }
	Ilya Sherman 2013/09/10 22:30:54 If you keep the bucketization strategy you've impl If you keep the bucketization strategy you've implemented here, please add some test coverage to verify that it is working correctly, if possible. This might mean you need to mock out the source of randomness somehow for testing, since it's fairly important to test that (a) a single website can land in multiple buckets and (b) a single website can't land in too many different buckets and (c) buckets are "equally weighted" in some sense. jdomingos 2013/09/11 15:50:30 Hi Ilya, The points (a) and (c), depend on the ra Show quoted text On 2013/09/10 22:30:54, Ilya Sherman wrote: > If you keep the bucketization strategy you've implemented here, please add some > test coverage to verify that it is working correctly, if possible. This might > mean you need to mock out the source of randomness somehow for testing, since > it's fairly important to test that (a) a single website can land in multiple > buckets and (b) a single website can't land in too many different buckets and > (c) buckets are "equally weighted" in some sense. Hi Ilya, The points (a) and (c), depend on the random value generation therefore I am wondering if we really need these tests.
OLD	NEW