Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3649)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 23140005: Added of new UMA signals in order to be able to discover early if the "save password" feature gets … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor changes Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | chrome/browser/password_manager/password_manager_metrics_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager.h
diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h
index 351f6e5fcc29e56e259c8f1c1ef85b52f7371a35..8f1447bded2c4c6ee21b7b3b3f766eceb156c6a3 100644
--- a/chrome/browser/password_manager/password_manager.h
+++ b/chrome/browser/password_manager/password_manager.h
@@ -114,7 +114,8 @@ class PasswordManager : public LoginModel,
};
// Log failure for UMA
- void RecordFailure(ProvisionalSaveFailure failure);
+ void RecordFailure(ProvisionalSaveFailure failure,
+ const std::string& url_host);
// Possibly set up FieldTrial for testing other possible usernames. This only
// happens if there are other_possible_usernames to be shown and the
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager.cc » ('j') | chrome/browser/password_manager/password_manager_metrics_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698