Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util.h

Index: chrome/browser/password_manager/password_manager_metrics_util.h
diff --git a/chrome/browser/password_manager/password_manager_metrics_util.h b/chrome/browser/password_manager/password_manager_metrics_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..9907b1fbf8e2f5a14f82f9e42e86323e135fbef8
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util.h
@@ -0,0 +1,47 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_
+
+#include <string>
+
+namespace base {
+class TimeDelta;
+}
+
+namespace password_manager_metrics_util {
+
+struct MonitoredWebsiteInfos {

[vabr (Chromium), 2013/09/10 08:46:53]

nit: Could we have a more descriptive name? "Infos" does not tell much. What
about DomainBucketsPair or something similar?

[jdomingos, 2013/09/10 16:49:13]

Done.

+  char const* domain_name;
+  int const bucketsID[10];

[vabr (Chromium), 2013/09/10 08:46:53]

hacker_style for member variables. Also (nit) -- the plural should be with IDs
not buckets. So suggesting:
bucket_ids

[jdomingos, 2013/09/10 16:49:13]

Done.

+};
+
+// Check whether the |url_host| is monitored or not. If yes, we return
+// the name of the group which contains the domain name otherwise
+// returns an empty string.
+std::string IsDomainNameMonitored(const std::string& url_host);
+
+// A version of the UMA_HISTOGRAM_ENUMERATION macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramEnumeration(const std::string& name,
+                                int sample,
+                                int boundary_value);
+
+// A version of the UMA_HISTOGRAM_TIMES macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramTimes(const std::string& name,
+                          const base::TimeDelta& duration);
+
+// A version of the UMA_HISTOGRAM_COUNT macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramCount(const std::string& name, int sample);
+
+// A version of the UMA_HISTOGRAM_BOOLEAN macro that allows the |name|
+// to vary over the program's runtime.
+void LogUMAHistogramBoolean(const std::string& name, bool sample);

[vabr (Chromium), 2013/09/10 08:46:53]

Looks like this function is not used. If so, then we should better remove it.

[jdomingos, 2013/09/10 16:49:13]

Done.

+
+}  // namespace password_manager_metrics_util
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_METRICS_UTIL_H_