Issue 2313923002: Don't close pinned notification by the close all button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2313923002: Don't close pinned notification by the close all button (Closed)

Created:
4 years, 3 months ago by yoshiki

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 Review-Url: https://codereview.chromium.org/2295923004 Cr-Commit-Position: refs/heads/master@{#415688} (cherry picked from commit d43f0e4397ca78e7eae53144c23a727b019e8ea2) Committed: https://chromium.googlesource.com/chromium/src/+/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -1 line)			Patch
	M	ui/message_center/message_center_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/message_center/message_center_impl_unittest.cc	View		1 chunk	+98 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

yoshiki

4 years, 3 months ago (2016-09-06 09:09:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7f30cd6e116fdab91a6127ae452e8f3edb78b7ed.