Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2295923004:
Don't close pinned notification by the close all button (Closed)
DescriptionDon't close pinned notification by the close all button
Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.
BUG=b/31022395
BUG=642827
Committed: https://crrev.com/d43f0e4397ca78e7eae53144c23a727b019e8ea2
Cr-Commit-Position: refs/heads/master@{#415688}
Patch Set 1 #
Messages
Total messages: 38 (32 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Description was changed from ========== . BUG= ========== to ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 ==========
yoshiki@chromium.org changed reviewers: + dewittj@chromium.org
Justin, PTAL. Thanks.
lgtm
The CQ bit was checked by yoshiki@chromium.org
The CQ bit was unchecked by yoshiki@chromium.org
Description was changed from ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 ========== to ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 ==========
The CQ bit was checked by yoshiki@chromium.org
On 2016/08/31 16:25:45, dewittj wrote: > lgtm Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 ========== to ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 ========== to ========== Don't close pinned notification by the close all button Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug. BUG=b/31022395 BUG=642827 Committed: https://crrev.com/d43f0e4397ca78e7eae53144c23a727b019e8ea2 Cr-Commit-Position: refs/heads/master@{#415688} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d43f0e4397ca78e7eae53144c23a727b019e8ea2 Cr-Commit-Position: refs/heads/master@{#415688} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
