Fix integer overflow in FEGaussianBlur::mapRect.

Fix integer overflow in FEGaussianBlur::mapRect.

This multiply should be done after the conversion to float, not before.

BUG=643587
Committed: https://crrev.com/35370e15f2dc7f79a23bba93ac0d99417489c175
Cr-Commit-Position: refs/heads/master@{#416702}

[jbroman, 2016-09-06 18:36:20]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-06 18:37:14]

jbroman@chromium.org changed reviewers:
+ senorblanco@chromium.org

[jbroman, 2016-09-06 18:37:15]

Incidentally, this file still does the three-box-blur calculation, even though
Skia has since switched to 3*sigma for its own. I'm not sure whether you want to
update it, but it's not necessary to resolve this bug.

[pdr., 2016-09-06 18:40:27]

On 2016/09/06 at 18:37:15, jbroman wrote:
> Incidentally, this file still does the three-box-blur calculation, even though
Skia has since switched to 3*sigma for its own. I'm not sure whether you want to
update it, but it's not necessary to resolve this bug.

Senorblanco is on vacation until the 12th.

Do we have similar issues in FilterOperation's outsetSizeForBlur and
FEDropShadow::mapRect?

[jbroman, 2016-09-06 18:43:00]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[jbroman, 2016-09-06 18:43:05]

jbroman@chromium.org changed reviewers:
+ pdr@chromium.org
- senorblanco@chromium.org

[jbroman, 2016-09-06 18:43:05]

Yes, we do. Changed (FEGaussianBlur is the one reported by ClusterFuzz).

[commit-bot: I haz the power, 2016-09-06 18:43:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-09-06 18:43:46]

On 2016/09/06 at 18:43:05, jbroman wrote:
> Yes, we do. Changed (FEGaussianBlur is the one reported by ClusterFuzz).

Thanks!

LGTM

[jbroman, 2016-09-06 18:44:06]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2016-09-06 18:44:09]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:44:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:29:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 20:31:31]

Description was changed from

==========
Fix integer overflow in FEGaussianBlur::mapRect.

This multiply should be done after the conversion to float, not before.

BUG=643587
==========

to

==========
Fix integer overflow in FEGaussianBlur::mapRect.

This multiply should be done after the conversion to float, not before.

BUG=643587

Committed: https://crrev.com/35370e15f2dc7f79a23bba93ac0d99417489c175
Cr-Commit-Position: refs/heads/master@{#416702}
==========

[commit-bot: I haz the power, 2016-09-06 20:31:33]

Patchset 2 (id:??) landed as
https://crrev.com/35370e15f2dc7f79a23bba93ac0d99417489c175
Cr-Commit-Position: refs/heads/master@{#416702}

[Stephen White, 2016-09-13 18:07:15]

Post-landing LGTM