third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp - Issue 2313883003: Fix integer overflow in FEGaussianBlur::mapRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

Issue 2313883003: Fix integer overflow in FEGaussianBlur::mapRect. (Closed)

Patch Set: .0f in two more places Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

index c7f5e5f89722d7f12b41f67e19272a85d3d4420a..c0f1e8a98fc0b852709beff061535a2f7e71a610 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

@@ -82,8 +82,8 @@ FloatRect FEGaussianBlur::mapRect(const FloatRect& rect, bool) const

IntSize kernelSize = calculateKernelSize(getFilter(), FloatPoint(m_stdX, m_stdY));

// We take the half kernel size and multiply it with three, because we run box blur three times.

- result.inflateX(3 * kernelSize.width() * 0.5f);

- result.inflateY(3 * kernelSize.height() * 0.5f);

+ result.inflateX(3.0f * kernelSize.width() * 0.5f);

+ result.inflateY(3.0f * kernelSize.height() * 0.5f);

return result;

}