Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2313863003: [arm] Improve Float(32|64)(Max|Min). (Closed)

Created:
4 years, 3 months ago by jbramley
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Improve Float(32|64)(Max|Min). ARMv8 can use vminnm and vmaxnm to handle most inputs. Other platforms use an implementation similar to what was there before, except that out-of-line code is used for the uncommon cases. BUG= Committed: https://crrev.com/3396bb290701c600dd600081f04803b14f0f9084 Cr-Commit-Position: refs/heads/master@{#39202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -131 lines) Patch
M src/arm/macro-assembler-arm.h View 3 chunks +38 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +144 lines, -4 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +67 lines, -122 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 4 chunks +233 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 3 months ago (2016-09-06 10:15:26 UTC) #2
Benedikt Meurer
LGTM, thanks for cleaning this up.
4 years, 3 months ago (2016-09-06 10:56:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313863003/1
4 years, 3 months ago (2016-09-06 11:03:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 11:27:45 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 11:28:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3396bb290701c600dd600081f04803b14f0f9084
Cr-Commit-Position: refs/heads/master@{#39202}

Powered by Google App Engine
This is Rietveld 408576698