Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2313523002: Add check that the CSSValue is a valid type in CSSTransformComponent before casting (Closed)

Created:
4 years, 3 months ago by meade_UTC10
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add check that the CSSValue is a valid type in CSSTransformComponent before casting. BUG=641995 Committed: https://crrev.com/5c7a196f1f2a29d7e71b5dcf2051dbe0625d6519 Cr-Commit-Position: refs/heads/master@{#417535}

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
meade_UTC10
4 years, 3 months ago (2016-09-05 04:56:17 UTC) #5
Timothy Loh
On 2016/09/05 04:56:17, Eddy wrote: Can you CC me on the bug?
4 years, 3 months ago (2016-09-05 04:57:05 UTC) #6
Timothy Loh
On 2016/09/05 04:57:05, Timothy Loh wrote: > On 2016/09/05 04:56:17, Eddy wrote: > > Can ...
4 years, 3 months ago (2016-09-05 08:34:17 UTC) #9
meade_UTC10
Added a test.
4 years, 3 months ago (2016-09-09 05:41:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313523002/20001
4 years, 3 months ago (2016-09-09 06:31:49 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 08:19:27 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 08:21:22 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c7a196f1f2a29d7e71b5dcf2051dbe0625d6519
Cr-Commit-Position: refs/heads/master@{#417535}

Powered by Google App Engine
This is Rietveld 408576698