third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp - Issue 2313523002: Add check that the CSSValue is a valid type in CSSTransformComponent before casting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp

Issue 2313523002: Add check that the CSSValue is a valid type in CSSTransformComponent before casting (Closed)

Patch Set: Add a test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp b/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp

index 5466fc8acc12deb4178a9cc542b9bd0e5de415ff..4345d0a870bd2f9db7653853234fa3ea11e357fc 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp

@@ -15,6 +15,9 @@ namespace blink {

CSSTransformComponent* CSSTransformComponent::fromCSSValue(const CSSValue& value)

{

+ if (!value.isFunctionValue())

+ return nullptr;

const CSSFunctionValue& functionValue = toCSSFunctionValue(value);

switch (functionValue.functionType()) {

case CSSValueMatrix:

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html ('k') | no next file » | no next file with comments »