Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2313513002: Restrict SVG filters to the filter bounds instead of an infinite rect (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict SVG filters to the filter bounds instead of an infinite rect This patch uses the SVG filter bounds when painting SVG filters instead of an infinite rect. Two SPV2 SVG filter tests have been marked as failing. These are expected because we do not yet support SVG filters in SPV2. BUG=642035 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/094d51a82e028ae151a224ec413cafeb9a910a09 Cr-Commit-Position: refs/heads/master@{#416549}

Patch Set 1 #

Patch Set 2 : Update spv2 expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
pdr.
Noticed this while reviewing your patch.
4 years, 3 months ago (2016-09-05 05:20:42 UTC) #8
pdr.
4 years, 3 months ago (2016-09-05 05:20:47 UTC) #9
fs
lgtm
4 years, 3 months ago (2016-09-05 07:58:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313513002/20001
4 years, 3 months ago (2016-09-05 15:32:50 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-05 15:36:07 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 15:37:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/094d51a82e028ae151a224ec413cafeb9a910a09
Cr-Commit-Position: refs/heads/master@{#416549}

Powered by Google App Engine
This is Rietveld 408576698