Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

Issue 2313513002: Restrict SVG filters to the filter bounds instead of an infinite rect (Closed)
Patch Set: Update spv2 expectations Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
index 5f2a8384db38e90aa496d92e3e7bdb89ed141115..6ca6fe6b75e9649302e72e06a5b02de30cf674e8 100644
--- a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
@@ -129,8 +129,8 @@ void SVGFilterPainter::finishEffect(const LayoutObject& object, SVGFilterRecordi
if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(context, object, DisplayItem::kSVGFilter))
return;
- // TODO(chrishtr): stop using an infinite rect, and instead bound the filter.
- LayoutObjectDrawingRecorder recorder(context, object, DisplayItem::kSVGFilter, LayoutRect::infiniteIntRect());
+ FloatRect filterRegion = filterData ? filterData->filter->filterRegion() : FloatRect();
+ LayoutObjectDrawingRecorder recorder(context, object, DisplayItem::kSVGFilter, filterRegion);
if (filterData && filterData->m_state == FilterData::ReadyToPaint)
paintFilteredContent(context, filterData);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698