Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_service_android.cc

Issue 2313413002: Pass JavaRef to Java methods in device/bluetooth. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_service_android.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_service_android.cc b/device/bluetooth/bluetooth_remote_gatt_service_android.cc
index e26326de51b55a3694f0928b24e3d17eb11e3e9f..71e33d9e406f19aaca6dbe175c4e0828f05f0eda 100644
--- a/device/bluetooth/bluetooth_remote_gatt_service_android.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_service_android.cc
@@ -15,6 +15,7 @@
using base::android::AttachCurrentThread;
using base::android::JavaParamRef;
+using base::android::JavaRef;
namespace device {
@@ -23,9 +24,11 @@ std::unique_ptr<BluetoothRemoteGattServiceAndroid>
BluetoothRemoteGattServiceAndroid::Create(
BluetoothAdapterAndroid* adapter,
BluetoothDeviceAndroid* device,
- jobject /* BluetoothGattServiceWrapper */ bluetooth_gatt_service_wrapper,
+ const JavaRef<
+ jobject>& /* BluetoothGattServiceWrapper */ bluetooth_gatt_service_wrapper,
Torne 2016/09/07 16:50:50 This line and others like it in the change end up
scheib 2016/09/07 18:00:30 I believe clang format will be happier if the comm
const std::string& instance_id,
- jobject /* ChromeBluetoothDevice */ chrome_bluetooth_device) {
+ const JavaRef<
+ jobject>& /* ChromeBluetoothDevice */ chrome_bluetooth_device) {
std::unique_ptr<BluetoothRemoteGattServiceAndroid> service(
new BluetoothRemoteGattServiceAndroid(adapter, device, instance_id));
« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_service_android.h ('k') | device/bluetooth/test/bluetooth_test_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698